Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Chinese translation v1.0 #60

Closed
wants to merge 69 commits into from
Closed

Conversation

linhe0x0
Copy link
Contributor

Ready for #38. The diagrams/images have not been translated yet, but we will finish these at the weekend. You can merge this one first. 😜

Translators: @XatMassacrE@L9m@Airmacho@xiaoyusilen@jifaxu

@donnemartin
Copy link
Owner

Hi @sqrthree, @XatMassacrE, @L9m, @Airmacho, @xiaoyusilen, @jifaxu, awesome work!

I'm thinking of squashing this PR into a single commit on merge to keep the history clean, otherwise we'd have to do a fair amount of rebasing to clean up the commit messages to bring them more in line with the current commit message history.

Just as an example, a commit message like "Modify again" I think could provide more detail on what was changed. I wonder if we could also standardize commit messages to be English.

Of course the downside of squash is that the individual commits would be combined into one. We could add an AUTHORS.md or TRANSLATORS.md file with credits for each language and translators, although it looks like there is already translator info in the new translated README, nice!

What do you think?

@linhe0x0
Copy link
Contributor Author

@donnemartin I have created a new branch to squash these commits. Now there's only one commit in the history. You can review it at #62.

@linhe0x0 linhe0x0 closed this Apr 15, 2017
@donnemartin
Copy link
Owner

Merged in #62, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants