Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds some initial OpenTelemetry metrics #1867

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Adds some initial OpenTelemetry metrics #1867

wants to merge 8 commits into from

Conversation

kallayj
Copy link
Contributor

@kallayj kallayj commented Oct 26, 2023

  1. Defines an interface on MqttServer supporting current session count, current client count, total successful connection count, and total messages published count metrics. Additional metrics would be supported by expanding this interface.
  2. Adds an MQTTnet.Extensions.Metrics project with a single AddMetrics extension method. The project takes a dependency on System.Diagnostics.DiagnosticSource package to provide the System.Diagnostics.Metrics behavior from .NET 7.0 to other .NET versions.

@kallayj
Copy link
Contributor Author

kallayj commented Oct 26, 2023

@dotnet-policy-service agree company="CARIAD Inc."

@kallayj kallayj marked this pull request as ready for review November 6, 2023 18:06
@kallayj
Copy link
Contributor Author

kallayj commented Nov 6, 2023

Converting from a draft to hopefully stimulate feedback from the repo maintainers.

@kallayj kallayj mentioned this pull request Nov 14, 2023
Open
@kallayj kallayj mentioned this pull request Dec 4, 2023
Merged
@kallayj kallayj changed the title Draft: adds some initial OpenTelemetry metrics Adds some initial OpenTelemetry metrics Dec 6, 2023
@kallayj
Copy link
Contributor Author

kallayj commented Dec 6, 2023

Updated with new metrics enabled by the merge of PR #1866 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kallayj