Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VerticalOffset Update When Modifying CollectionView.ItemsSource While Scrolled #26782

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

devanathan-vaithiyanathan
Copy link
Contributor

@devanathan-vaithiyanathan devanathan-vaithiyanathan commented Dec 23, 2024

Issue Details

When modifying the CollectionView.ItemsSource while scrolled down in the list on Android, the ItemsViewScrolledEventArgs.VerticalOffset is not updated correctly. The offset "0" should always represent the start of the collection, but instead, it changes inconsistently when items are added or removed. This issue appears when the collection is scrolled beyond the position of the added or deleted items.

Root Cause

The offsets (VerticalOffset and HorizontalOffset) were being calculated incrementally and did not reset properly when the ItemsSource changed, leading to incorrect offset values.

Description of Change

The change resets the VerticalOffset and HorizontalOffset to 0 when the ItemsSource is updated. This ensures correct offset values after adding or removing items, fixing the issue of incorrect offsets while scrolling.

Issues Fixed

Fixes #21708

Validated the behaviour in the following platforms

  • Android
  • Windows
  • iOS
  • Mac

Output Screenshot

Before After
Before.mov
After.mov

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 23, 2024
Copy link
Contributor

Hey there @devanathan-vaithiyanathan! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@sheiksyedm sheiksyedm added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 23, 2024
@devanathan-vaithiyanathan devanathan-vaithiyanathan marked this pull request as ready for review December 24, 2024 08:15
@devanathan-vaithiyanathan devanathan-vaithiyanathan requested a review from a team as a code owner December 24, 2024 08:15
@PureWeen PureWeen added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectionView.Scrolled event offset isn't correctly reset when items change on Android
3 participants