Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0] fix browser-wasm debug build #110943

Open
wants to merge 1 commit into
base: release/9.0
Choose a base branch
from

Conversation

srxqds
Copy link
Contributor

@srxqds srxqds commented Dec 25, 2024

Backport of #108185

@pavelsavara
Copy link
Member

This PR adds the profiler-log component into default build (which people ship when they don't use wasm workload). I'm not sure we want to merge this.

@srxqds what's your intention here ?

Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@srxqds
Copy link
Contributor Author

srxqds commented Dec 26, 2024

This PR adds the profiler-log component into default build (which people ship when they don't use wasm workload). I'm not sure we want to merge this.

@srxqds what's your intention here ?

we build debug local, it will hit undefined symbol mono_profiler_log_init when build drive.c

I found the main branch have fixed from this pr #108185

@pavelsavara pavelsavara changed the title fix browser-wasm debug build [release/9.0] fix browser-wasm debug build Dec 27, 2024
@pavelsavara
Copy link
Member

This PR adds the profiler-log component into default build (which people ship when they don't use wasm workload). I'm not sure we want to merge this.
@srxqds what's your intention here ?

we build debug local, it will hit undefined symbol mono_profiler_log_init when build drive.c

I found the main branch have fixed from this pr #108185

Thank you for explanation.

@lewing do you think this meets servicing bar ?

cc @maraf

@pavelsavara pavelsavara added the os-browser Browser variant of arch-wasm label Dec 27, 2024
@pavelsavara pavelsavara added this to the 9.0.x milestone Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch-wasm WebAssembly architecture area-Build-mono community-contribution Indicates that the PR has been added by a community member os-browser Browser variant of arch-wasm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants