Skip to content
This repository has been archived by the owner on Sep 9, 2022. It is now read-only.

Changed "tags {" to "tags = {" as required by terraform 0.12 #442

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dimitriosoodle
Copy link

Terraform 0.12 requires tags = { since tags is a map attribute see issue #19240 hashicorp/terraform#19240

@coveralls
Copy link

coveralls commented Jan 4, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling a99dd96 on dimitriosoodle:tags-need-equal-sign into 67cb929 on dtan4:master.

Copy link
Owner

@dtan4 dtan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review 🙇 Please do the followings to merge.

  • Please merge the current master and resolve conflicts
  • Please update unit tests

Is this change works well with Terraform 0.11.x and below?

@dimitriosoodle
Copy link
Author

I have tested terraform 0.11.3 and the changed seem to work

@dimitriosoodle
Copy link
Author

I have pulled the latest changes, dealt with conflicts and new features and addresses the unit tests.

@ARSport
Copy link

ARSport commented Jun 4, 2020

@dtan4 Any way this is getting merged any time soon? This is a great fix and a big miss to the latest terraform versions.
Thanks @dtan4 and @dimitriosoodle for your support!

@dimitriosoodle dimitriosoodle requested a review from dtan4 October 7, 2020 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants