Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(event): fix gesture zoom not working #892

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(event): fix gesture zoom not working #892

wants to merge 2 commits into from

Conversation

justorez
Copy link

@justorez justorez commented Feb 24, 2023 •
edited
Loading

Event error with preventDefault.

event error

@justorez
fix(event): fix "dataZoom" doesn't work
b17eccf 
Event error with preventDefault.
@justorez justorez changed the title fix(event): fix "dataZoom" doesn't work fix(event): fix gesture zoom not working Feb 25, 2023
Ovilia
Ovilia requested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be right. If () => {} is used, the event can never be stopped from propagation.

@justorez
Copy link
Author

justorez commented Mar 3, 2023 •
edited
Loading

微信小程序的事件对象没有这三种方法，我注意到之前的提交也是这么写的 5d1ef47.

@justorez justorez requested a review from Ovilia March 8, 2023 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ovilia Ovilia Awaiting requested review from Ovilia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justorez @Ovilia