-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: pin system requirements to favor controlled updates #30
Conversation
27c9593
to
e4c57f5
Compare
For anyone joining the conversation: The build service was temporarily unavailable because of the
Which caused the error I mentioned in the cover letter: https://github.com/eduNEXT/ednx-strains/actions/runs/11364833228/job/31611954196 The upgrade has been temporarily rolled out from production while the GH runner-images team figures out how to fix it. This means we're currently running with Ubuntu-latest (Ubuntu-22.04). Although the error was temporarily fixed, this opens a bigger conversation for the Picasso maintenance team. Should we pin environment-wide requirements like Ubuntu / Python to favor more controlled updates? I'd say pinning both is worth considering. |
run: | | ||
pip install pyyaml | ||
pip install -r picasso/requirements/base.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better, thanks
58d440c
to
25bfa21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mariajgrimaldi, LGTM
Description
This PR pins the runner system requirements (like Ubuntu version and Python) to specific versions to avoid errors when GH automatically updates its runner images. Also, before upgrading, we need to ensure all of our in-house tutor plugins support Python 3.12.
These changes were initially motivated by this error raised in recent runs of the workflow: https://github.com/eduNEXT/ednx-strains/actions/runs/11364833228/job/31611954196, which was caused by the ubuntu-latest image being updated to ubuntu-24.04 on Oct 6th.
See #30 (comment) for more details on the motivation for this PR.