Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: pin system requirements to favor controlled updates #30

Merged
merged 17 commits into from
Nov 13, 2024

Conversation

mariajgrimaldi
Copy link
Contributor

@mariajgrimaldi mariajgrimaldi commented Oct 16, 2024

Description

This PR pins the runner system requirements (like Ubuntu version and Python) to specific versions to avoid errors when GH automatically updates its runner images. Also, before upgrading, we need to ensure all of our in-house tutor plugins support Python 3.12.

These changes were initially motivated by this error raised in recent runs of the workflow: https://github.com/eduNEXT/ednx-strains/actions/runs/11364833228/job/31611954196, which was caused by the ubuntu-latest image being updated to ubuntu-24.04 on Oct 6th.

See #30 (comment) for more details on the motivation for this PR.

@mariajgrimaldi mariajgrimaldi force-pushed the MJG/fix-externally-managed-env branch from 27c9593 to e4c57f5 Compare October 16, 2024 13:03
@mariajgrimaldi mariajgrimaldi marked this pull request as ready for review October 17, 2024 19:32
@mariajgrimaldi mariajgrimaldi requested a review from a team as a code owner October 17, 2024 19:32
requirements/base.txt Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@mariajgrimaldi
Copy link
Contributor Author

mariajgrimaldi commented Oct 18, 2024

For anyone joining the conversation:

The build service was temporarily unavailable because of the ubuntu-latest update from ubuntu-22.04 to ubuntu-24.04. Specifically, actions/runner-images#10781

The root cause of the problem is that the image being used for the ubuntu-24.04 runners is using the python interpreter which ships with the OS, which is externally managed

Which caused the error I mentioned in the cover letter: https://github.com/eduNEXT/ednx-strains/actions/runs/11364833228/job/31611954196

The upgrade has been temporarily rolled out from production while the GH runner-images team figures out how to fix it. This means we're currently running with Ubuntu-latest (Ubuntu-22.04).

Although the error was temporarily fixed, this opens a bigger conversation for the Picasso maintenance team. Should we pin environment-wide requirements like Ubuntu / Python to favor more controlled updates? I'd say pinning both is worth considering.

run: |
pip install pyyaml
pip install -r picasso/requirements/base.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks

.github/workflows/build.yml Outdated Show resolved Hide resolved
Copy link

@magajh magajh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mariajgrimaldi, LGTM

@mariajgrimaldi mariajgrimaldi merged commit 0da956a into main Nov 13, 2024
1 check passed
@mariajgrimaldi mariajgrimaldi deleted the MJG/fix-externally-managed-env branch November 13, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants