Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add WebContentsView API example #1668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Add WebContentsView API example #1668

wants to merge 1 commit into from

Conversation

Santhoshmani1
Copy link
Contributor

Related #1648

  • Add WebContentsView API example to show-me examples.

image
image

@Santhoshmani1 Santhoshmani1 requested review from codebytere and a team as code owners December 18, 2024 09:10
BlackHole1
BlackHole1 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@BlackHole1 BlackHole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

erickzhao
erickzhao reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@electron/wg-ecosystem thoughts on marking the existing BrowserView example as deprecated or just removing it altogether?

@coveralls
Copy link

Coverage Status

coverage: 87.604%. remained the same
when pulling 49421c2 on Santhoshmani1:add-webcontentsview-example
into 9eb162c on electron:main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzhao erickzhao erickzhao left review comments

@BlackHole1 BlackHole1 BlackHole1 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Santhoshmani1 @coveralls @codebytere @BlackHole1 @erickzhao