Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(makerdeb): Add name option and fix bin name #3726

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

coredev-uk
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
Basically as the title says, this implements a rename function to correct the file name of the .deb output to the user specified value. This also corrects the bin name to enforce the use of the executableName. In situations where the app name in the package.json does not match the executableName in the packagerConfig it errors due to package generating an executable following the executableName value which is not what MakerDeb is expecting.

fix: Apply the executable name correctly over using package name
@coredev-uk coredev-uk requested a review from a team as a code owner October 2, 2024 01:18
@coredev-uk
Copy link
Author

I might adapt this PR to allow the user to change the full name (AppName, Version and Arch) for all the makers, similar to how it is done in the ReForged AppImage Maker. Even though the naming option is not something that really effects the user, it removes the step in any release workflow, making it easier for everyone.

@felixrieseberg
Copy link
Member

This looks good, thanks for the contribution @coredev-uk! The only question I have is whether or not this might be a breaking change for anyone - what's your take?

@coredev-uk
Copy link
Author

coredev-uk commented Oct 19, 2024

This does slightly change the default file name, current structure is $NAME-$PLATFORM-$ARCH-$VERSION-$DEBARCH.deb, this PR does change it to a simpler format which could potentially cause some issues in a CI environment if people are explicitly setting the filename. Would you suggest I set the default to the current one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants