feat(makerdeb): Add name option and fix bin name #3726
+7
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
Basically as the title says, this implements a rename function to correct the file name of the
.deb
output to the user specified value. This also corrects the bin name to enforce the use of theexecutableName
. In situations where the app name in thepackage.json
does not match theexecutableName
in thepackagerConfig
it errors due to package generating an executable following theexecutableName
value which is not whatMakerDeb
is expecting.