Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update native module unpack pattern to include hidden directories #3793

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update native module unpack pattern to include hidden directories #3793

wants to merge 1 commit into from
+1 −1

Conversation

glowingjade
Copy link

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
fixed #3792

@glowingjade glowingjade requested a review from a team as a code owner December 25, 2024 02:55
@glowingjade glowingjade mentioned this pull request Dec 25, 2024
Open
3 tasks
nikwen
nikwen reviewed Dec 27, 2024
View reviewed changes
Copy link

@nikwen nikwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

packages/plugin/auto-unpack-natives/src/AutoUnpackNativesPlugin.ts
@@ -23,7 +23,7 @@ export default class AutoUnpackNativesPlugin extends PluginBase<AutoUnpackNative
forgeConfig.packagerConfig.asar = {};
}
const existingUnpack = forgeConfig.packagerConfig.asar.unpack;
const newUnpack = '**/*.node';
const newUnpack = '**/{.webpack,**}/**/*.node';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to solve it that makes it work for all hidden directories, not just .webpack?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikwen nikwen nikwen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AutoUnpackNativesPlugin fails to unpack native modules from hidden directories
2 participants
@glowingjade @nikwen