Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truststore #3409

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Truststore #3409

wants to merge 21 commits into from

Conversation

tomchristie
Copy link
Member

@tomchristie tomchristie commented Nov 21, 2024

Refs #302.

Switch from certifi to truststore in order to enable system trust stores as our default SSL behavior. Related… #3404 (comment)

Requires us to bump our Python requirement from 3.8 to 3.10.

docs/advanced/ssl.md Outdated Show resolved Hide resolved
@tomchristie tomchristie mentioned this pull request Nov 22, 2024
@tomchristie tomchristie marked this pull request as ready for review November 28, 2024 11:41
@tomchristie
Copy link
Member Author

tomchristie commented Nov 28, 2024

Looking at PyPI stats we've currently still got fairly significant 3.9 usage.

Perhaps a smart approach here would be...

  • Plan on switching from certifi to truststore with a release aimed at 2025-10.
  • At the same time as Python 3.9 becomes EOL.
  • And Python 3.14 is released.

(Alternatively we could be more pushy about this with our userbase. 2025-10 seems like a long time to wait for this.)

@Secrus
Copy link
Contributor

Secrus commented Dec 4, 2024

Maybe it could be done based on python version? certifi for <3.10 and truststore for the rest?

@tomchristie
Copy link
Member Author

@Secrus - Could phase it in gradually yep. Or eg... support it in Python 3.14.
I really don't have enough context to know how to take a call on this one.

@zanieb
Copy link
Contributor

zanieb commented Dec 6, 2024

I would be uncomfortable dropping support for Python 3.9 before EOL, but it is worth noting there are other ecosystem packages that do this, e.g., numpy has an aggressive Python support schedule and dropped Python 3.9 support earlier this year numpy/numpy#26222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants