Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ses): removeUnpermittedIntrinsics on Hermes #2655

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix(ses): removeUnpermittedIntrinsics on Hermes #2655

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce43f37
fix(ses): removeUnpermittedIntrinsics on Hermes via dynamic permit at…
leotm Dec 11, 2024
031bed4
refactor(ses): document removeUnpermittedIntrinsics now fixed in Stat…
leotm Dec 18, 2024
fb31aca
feat(ses): restrict dynamic permit on Hermes
leotm Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion packages/ses/src/permits.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
/* eslint-disable no-restricted-globals */
/* eslint max-lines: 0 */

import { arrayPush } from './commons.js';
import { arrayPush, arrayForEach } from './commons.js';

/** @import {GenericErrorConstructor} from '../types.js' */

Expand Down Expand Up @@ -299,6 +299,24 @@ const accessor = {
set: fn,
};

// eslint-disable-next-line func-names
const strict = function () {
'use strict';
};

// TODO Remove this once we no longer support the Hermes that needed this.
arrayForEach(['caller', 'arguments'], prop => {
try {
strict[prop];
} catch (e) {
// https://github.com/facebook/hermes/blob/main/test/hermes/function-non-strict.js
if (e.message === 'Restricted in strict mode') {
// Fixed in Static Hermes: https://github.com/facebook/hermes/issues/1582
FunctionInstance[prop] = accessor;
}
}
});

export const isAccessorPermit = permit => {
return permit === getter || permit === accessor;
};
Expand Down
Loading