Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[augerctl] Support for the json format as output #94

Merged
merged 2 commits into from
Sep 3, 2024
Merged

[augerctl] Support for the json format as output #94

merged 2 commits into from
Sep 3, 2024
+74 −31

Conversation

wzshiming
Copy link
Member

part of #3

@wzshiming wzshiming force-pushed the feat/augerctl-get-format-json branch from 0bf3403 to 8c4cd88 Compare August 14, 2024 02:43
@wzshiming
Copy link
Member Author

/cc @jmhbnz
/cc @siyuanfoundation

jmhbnz
jmhbnz reviewed Aug 24, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating this out @wzshiming. One question below:

augerctl/command/printer.go Show resolved Hide resolved
@wzshiming wzshiming force-pushed the feat/augerctl-get-format-json branch 2 times, most recently from 270d3ed to 7a5cece Compare August 26, 2024 05:41
@wzshiming wzshiming force-pushed the feat/augerctl-get-format-json branch from 7a5cece to 78af937 Compare August 26, 2024 05:41
@wzshiming
Copy link
Member Author

wzshiming commented Aug 26, 2024 •
edited
Loading

Done

I tend to think of json output as more machine parse-able format and I couldn't see any flag to just output raw json only.

That makes sense, I've split it up.

@wzshiming wzshiming requested a review from jmhbnz August 26, 2024 05:42
@wzshiming wzshiming changed the title [aurgerctl] Support for the json format as output [augerctl] Support for the json format as output Aug 26, 2024
@wzshiming
Clean up printer yaml
4af761f 
Signed-off-by: Shiming Zhang <[email protected]>
@wzshiming wzshiming force-pushed the feat/augerctl-get-format-json branch from 1aa73fb to 4af761f Compare August 26, 2024 05:56
jmhbnz
jmhbnz approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @wzshiming

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmhbnz, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 7585c33 into etcd-io:main Sep 3, 2024
3 checks passed
@wzshiming wzshiming deleted the feat/augerctl-get-format-json branch September 3, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@siyuanfoundation siyuanfoundation Awaiting requested review from siyuanfoundation

Assignees
No one assigned
Labels
approved size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wzshiming @k8s-ci-robot @jmhbnz