Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the time e2e tests take #18983

Open
serathius opened this issue Dec 2, 2024 · 3 comments
Open

Reduce the time e2e tests take #18983

serathius opened this issue Dec 2, 2024 · 3 comments

Comments

@serathius
Copy link
Member

What would you like to be added?

E2e tests are taking over 40 minutes now, we should keep them unver 30 minutes or even lower.

For the top test candidates to optimize use https://testgrid.k8s.io/sig-etcd-periodics#ci-etcd-e2e-amd64&graph-metrics=test-duration-minutes

Current state

  • go.etcd.io/etcd/tests/v3/common.TestMemberAdd > 5 minutes
  • go.etcd.io/etcd/tests/v3/common.TestMemberRemove > 2 minutes
  • go.etcd.io/etcd/tests/v3/e2e.TestAuthority > 1.5 minutes
  • go.etcd.io/etcd/tests/v3/e2e.TestRuntimeReconfigGrowClusterSize > 1 minute
  • go.etcd.io/etcd/tests/v3/common.TestUserAdd_Simple > 1 minute
  • go.etcd.io/etcd/tests/v3/common.TestLeaseGrantAndList ~ 50 seconds
  • go.etcd.io/etcd/tests/v3/e2e.TestVerifyHashKVAfterCompact ~50 seconds
  • go.etcd.io/etcd/tests/v3/e2e.TestMixVersionsSnapshotByMockingPartition ~ 40 seconds
  • go.etcd.io/etcd/tests/v3/common.TestKVDelete ~ 40 seconds
  • go.etcd.io/etcd/tests/v3/common.TestLeaseGrantTimeToLiveExpired ~ 35 seconds
  • go.etcd.io/etcd/tests/v3/e2e.TestWatchDelayForManualProgressNotification ~ 35 seconds
    ...

Looking for someone to take a look at the top tests and propose improvements to reduce runtime

image

Why is this needed?

We should keep the test execution time low to ensure good contributor expirience.

@serathius
Copy link
Member Author

/cc @ahrtr @jmhbnz @ivanvc
/help

@manthanguptaa
Copy link
Contributor

@serathius I can take a look at this

@ivanvc
Copy link
Member

ivanvc commented Dec 5, 2024

Thanks, @manthanguptaa!

/assign @manthanguptaa

AwesomePatrol added a commit to AwesomePatrol/etcd that referenced this issue Dec 10, 2024
On my local machine it brings down execution time from 3 minutes to 19s.

Issue: etcd-io#18983
Change-Id: I5e1d31e2e06b66f75890b942ec5ad792f1a551a1
AwesomePatrol added a commit to AwesomePatrol/etcd that referenced this issue Dec 10, 2024
On my local machine it brings down execution time from 3 minutes to 19s.

Issue: etcd-io#18983
Signed-off-by: Aleksander Mistewicz <[email protected]>
AwesomePatrol added a commit to AwesomePatrol/etcd that referenced this issue Dec 10, 2024
On my local machine it brings down execution time from 5m to 32s.

Issue: etcd-io#18983
Signed-off-by: Aleksander Mistewicz <[email protected]>
AwesomePatrol added a commit to AwesomePatrol/etcd that referenced this issue Dec 11, 2024
On my local machine it brings down execution time from 5m to 32s.

Issue: etcd-io#18983
Signed-off-by: Aleksander Mistewicz <[email protected]>
AwesomePatrol added a commit to AwesomePatrol/etcd that referenced this issue Dec 11, 2024
On my local machine it brings down execution time from 5m to 32s.

Issue: etcd-io#18983
Signed-off-by: Aleksander Mistewicz <[email protected]>
AwesomePatrol added a commit to AwesomePatrol/etcd that referenced this issue Dec 12, 2024
Introduce port allocator and remove unused MemberNumber.

On my local machine it brings down execution time from 5m to 32s.

Issue: etcd-io#18983
Signed-off-by: Aleksander Mistewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants