Improve EthereumListener #1152

eugene-shevchenko · 2018-08-10T15:53:50Z

This PR covers issue #1138.

Adds Publisher abstraction that implements pub/sub model to deliver events from publisher to subscriber.
Replaces CompositeEthereumListener / EthereumListenerAdaptor / EthereumListener using with new event publishing mechanism.
Keeps backward compatibility with old event handling model.

…ion.

…ging.

mkalinin

We also need to add all possible use cases of new feature in some sample. I think it's better to create a brand new sample that shows publisher features only.

mkalinin · 2018-08-13T05:11:39Z

ethereumj-core/src/main/java/org/ethereum/config/CommonConfig.java

+
+    @Bean
+    public EthereumListener ethereumListener(Publisher publisher) {
+        return publisher.asListener();


I am thinking of keeping old listeners and new pub/sub scheme completely decoupled from each other. This is about stable backward compatibility, there is just much smaller chance to break something.

In addition to stable backward compatibility we may leave such things like trace(), onPendingTransactionReceived(), onBlock(BlockSummary summary) behind

Do you mean to move backward compatibility logic from Publisher to external adapter class, to keep Publisher code clean?

For each callback from EthereumListener exists similar Event type, that could be fired and caught.

I mean that it makes sense to keep both old listener which stays unchanged and a publisher. Listener will be marked as deprecated and publisher won't include already deprecated parts like onPendingTransactionReceived() method

mkalinin · 2018-08-13T05:15:06Z

ethereumj-core/src/main/java/org/ethereum/config/CommonConfig.java

@@ -290,14 +300,14 @@ public DbFlushManager dbFlushManager() {
    }

    @Bean
-    public BlockHeaderValidator headerValidator() {
+    public BlockHeaderValidator headerValidator(SystemProperties systemProperties, Publisher publisher) {


I don't think it'll be handy in all cases.
Let's say you need to get headerValidator out of CommonConfig then you will have to make a tricky call like commonConfig.headerValidator(commonConfig.systemProperties(), commonConfig.publisher()) instead of just commonConfig.headerValidator()

@eugene-shevchenko any thoughts on that?

The method uses only in java config, and as I mentioned earlier such bean definition hides component dependencies. With no arguments option I should invoke three factory methods in method's body to get necessary dependencies. But if you think that no-args option is better I can revert method's signature.

PS: It's sad that java config which should configure ApplicationContext only, we use like object factory.

I think it's not a bad thing if we want to get rid of Spring one day.
It's more deterministic way.

mkalinin · 2018-08-13T05:15:31Z

ethereumj-core/src/main/java/org/ethereum/core/BlockchainImpl.java

-import java.util.NoSuchElementException;
-import java.util.Set;
-import java.util.Stack;
+import java.util.*;


We try to avoid wildcard import.

Ok, I'll move back direct class import. It's just IDEA automatic import optimizer.

Actually, it depends on configuration. You may disable wildcards in idea.

mkalinin · 2018-08-13T05:16:50Z

ethereumj-core/src/main/java/org/ethereum/core/BlockchainImpl.java

-            listener.trace(String.format("Block chain size: [ %d ]", this.getSize()));
+            publisher
+                    .publish(new BlockAddedEvent(summary))
+                    .publish(new BestBlockAddedEvent(summary, ret == IMPORTED_BEST))


Basically, if we decouple old listener from publisher then BestBlockAddedEvent won't be needed at all.

It was added for backward compatibility. The old code had default callback implementation with data proxing. So to fire such client code in a new fashion we need generate both events.
I agree, that we should leave only one event, when we'll completely remove EthereumListener.

mkalinin · 2018-08-13T05:18:02Z

ethereumj-core/src/main/java/org/ethereum/core/PendingStateImpl.java

@@ -46,6 +36,9 @@
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.stereotype.Component;

+import java.util.*;


See wildcard import comment above

mkalinin · 2018-08-13T11:28:24Z

ethereumj-core/src/main/java/org/ethereum/publish/event/BlockAddedEvent.java

+
+import org.ethereum.core.BlockSummary;
+
+public class BlockAddedEvent extends Event<BlockSummary> {


This one and previous should be merged into a single event if we decouple new publisher from old listener

mkalinin · 2018-08-13T11:30:15Z

ethereumj-core/src/main/java/org/ethereum/publish/event/NoConnectionsEvent.java

@@ -0,0 +1,4 @@
+package org.ethereum.publish.event;
+
+public class NoConnectionsEvent extends SignalEvent {


I didn't see any calls that uses this event. Is it ever instantiated?

Yep, it was created for correspond EthereumListener callback, before all invocations were migrated. I'll remove it.

mkalinin · 2018-08-13T11:33:38Z

ethereumj-core/src/main/java/org/ethereum/publish/event/BestBlockAddedEvent.java

+
+import org.ethereum.core.BlockSummary;
+
+public class BestBlockAddedEvent extends Event<BestBlockAddedEvent.Data> {


I'd omit Event suffix in each class. Class names like BestBlockAdded sufficient enough to understand that instantiated object is an event.

Can't argue with that :) I had the same idea too, cause sometimes such naming lead to worst enterprise apps class names. Will rename all events.

mkalinin · 2018-08-13T11:37:35Z

ethereumj-core/src/main/java/org/ethereum/publish/event/Single.java

+ *
+ * @author Eugene Shevchenko
+ */
+public interface Single {


It's better to call it OneOffEvent

mkalinin · 2018-08-13T15:55:07Z

ethereumj-core/src/main/java/org/ethereum/publish/exprimental/EventBus.java

+
+import static java.util.Objects.isNull;
+
+public class EventBus {


Maybe it is better to move experimental stuff to a separate branch?

I'll remove this package completely.

coveralls · 2018-08-14T11:16:13Z

Coverage decreased (-0.07%) to 56.169% when pulling 698b59a on feature/1138-event-listener-improve into 5c808c1 on develop.

zilm13 · 2018-08-14T22:35:03Z

ethereumj-core/src/main/java/org/ethereum/facade/EthereumImpl.java

+    @PostConstruct
+    public void init() {
+        publisher.subscribe(to(BlockAdded.class, data -> {
+            data.getBlockSummary().getBlock().getTransactionsList().forEach(gasPriceTracker::onTransaction);


this logic should be somewhere in gasPriceTracker instead

mkalinin

Also, new files lacks License header.

mkalinin · 2018-08-21T06:32:03Z

ethereumj-core/src/main/java/org/ethereum/config/CommonConfig.java

@@ -290,14 +300,14 @@ public DbFlushManager dbFlushManager() {
    }

    @Bean
-    public BlockHeaderValidator headerValidator() {
+    public BlockHeaderValidator headerValidator(SystemProperties systemProperties, Publisher publisher) {


@eugene-shevchenko any thoughts on that?

mkalinin · 2018-08-22T05:08:23Z

ethereumj-core/src/main/java/org/ethereum/facade/Ethereum.java

+     * @see Publisher
+     * @see Event
+     */
+    Publisher subscribe(Subscription subscription);


As a user I'd rather expect subscribe(Class type, Consumer handler); which is clearer. But we have to use generics though to make it really convenient:
<T> Publisher subscribe(Class<? extends Event<T>> type, Consumer<T> handler);

I'll add two overloaded methods:

<T> Publisher subscribe(Class<? extends Event<T>> type, Consumer<T> handler);

<T> Publisher subscribe(Class<? extends Event<T>> type, BiConsumer<T, Subscription.LifeCycle> handler);
but we need current method too, cause sometimes we are in want of Subscription instance.

We should add some handy links where user could see available type of Events. Current user entrance could stuck without samples.

Each of samples migrated to the new feature, so I guess it's not problem. Also we have utility class Events for convenience instantiation all of supported events. I'd rather actualize Publisher javadoc to refer user to all necessary classes.

Before this update user was adding listener by extending EthereumListenerAdapter, he got the view of all available listening options in one click. Since this update he should write .subscribe( and what's next? Samples are not the answer, not everyone can find them and you will not go to samples every time you need to add listener, Subscription class looks difficult from the first view, events are different classes in some package somewhere, not listed in one place. So the idea is that main entrance should look handy and simplify user's usage. I'm not sure what's the best way to do it but current entrance could stuck most of users.

mkalinin · 2018-08-22T05:11:08Z

...umj-core/src/main/java/org/ethereum/listener/BackwardCompatibilityEthereumListenerProxy.java

+    @Override
+    public void onNodeDiscovered(Node node) {
+        compositeListener.onNodeDiscovered(node);
+        publisher.publish(Events.onNodeDiscovered(node));


Maybe use static import for Events?

Nope, we have several methods with the same signature in both classes. That's why we should use full name in this case. In addition it's temporary class, so it's not critical I suppose.

ethereumj-core/src/main/java/org/ethereum/config/CommonConfig.java

mkalinin · 2018-08-22T05:15:33Z

ethereumj-core/src/main/java/org/ethereum/listener/CompositeEthereumListener.java

+    private final List<EthereumListener> listeners;
+
+
+    public CompositeEthereumListener(Executor executor) {


Why do we have anything to update in deprecated class?

Firstly field injection is bad practice cause it hides component dependencies. But in this case it's not critical because class marked as deprecated.
I moved bean definition to java config to highlight that old and new components use the same Executor. And then both Publisher and deprecated CompositeEthereumListener injects into BackwardCompatibilityEthereumListenerProxy. IMHO it's more obvious and helps avoid dependency mess.

This also applies to the previous comment.

mkalinin · 2018-08-22T05:17:44Z

ethereumj-core/src/main/java/org/ethereum/listener/EthereumListener.java

@@ -150,4 +160,86 @@ default void onBlock(BlockSummary blockSummary, boolean best) {
    void onTransactionExecuted(TransactionExecutionSummary summary);

    void onPeerAddedToSyncPool(Channel peer);
+
+    EthereumListener STUB = new EthereumListener() {


I don't think this either necessary. Let it use old deprecated EthereumListenerAdapter

Ok, I'll replace it with EthereumListenerAdapter

mkalinin · 2018-08-22T05:20:29Z

ethereumj-core/src/main/java/org/ethereum/listener/RecommendedGasPriceTracker.java

@@ -38,7 +38,7 @@
 * (if {@link #getPercentileShare()} is not overridden) of the latest transactions were
 * executed at this or lower price.
 */
-public class RecommendedGasPriceTracker extends EthereumListenerAdapter {
+public class RecommendedGasPriceTracker {


This change breaks backward compatibility. We also need to introduce a mechanism for easy subscribing to the new publisher.

Does anyone use this class except us? I thought that this class for our internal logic only.

We recommend to use this class in 'official' docs:

ethereumj/ethereumj-core/src/main/java/org/ethereum/facade/Ethereum.java

Line 214 in be261fa

* want to get accurate recommended gas price use {@link org.ethereum.listener.RecommendedGasPriceTracker}

If it's not pretty necessary we should preserve backward compatibility, to not force EthJ lib users to rewrite their code after each major update

Ok, I'll revert this change.

By the way we use this class nowhere =)

mkalinin · 2018-08-22T05:30:24Z

ethereumj-core/src/main/java/org/ethereum/publish/event/BlockAdded.java

+    public BlockAdded(BlockSummary blockSummary, boolean best) {
+        super(new Data(blockSummary, best));
+    }
+}


mkalinin · 2018-08-22T05:50:48Z

ethereumj-core/src/main/java/org/ethereum/publish/LifeCycleSubscription.java

+ *
+ * @author Eugene Shevchenko
+ */
+public class LifeCycleSubscription<E extends Event<D>, D> extends Subscription<E, D> {


I bet we don't need yet another abstraction here. Introducing it makes an API less obvious for users. I am more about to have two constructors for Subscription, one with BiConsumer, another one with Consumer that is extended to BiConsumer during construction.

Ok, I'll move this functionality to Subscription

eugene-shevchenko · 2018-08-22T18:52:20Z

ethereumj-core/src/main/java/org/ethereum/publish/LifeCycleSubscription.java

+ */
+public class LifeCycleSubscription<E extends Event<D>, D> extends Subscription<E, D> {
+
+    public static class LifeCycle {


@mkalinin Sorry, I removed your comment accidentally

…dapter instance.

eugene-shevchenko · 2018-08-22T18:52:20Z

ethereumj-core/src/main/java/org/ethereum/publish/LifeCycleSubscription.java

+ */
+public class LifeCycleSubscription<E extends Event<D>, D> extends Subscription<E, D> {
+
+    public static class LifeCycle {


@mkalinin Sorry, I removed your comment accidentally

zilm13 · 2018-09-20T21:05:33Z

ethereumj-core/src/main/java/org/ethereum/config/CommonConfig.java

@@ -290,14 +300,14 @@ public DbFlushManager dbFlushManager() {
    }

    @Bean
-    public BlockHeaderValidator headerValidator() {
+    public BlockHeaderValidator headerValidator(SystemProperties systemProperties, Publisher publisher) {


I think it's not a bad thing if we want to get rid of Spring one day.
It's more deterministic way.

zilm13 · 2018-09-20T21:09:58Z

ethereumj-core/src/main/java/org/ethereum/core/BlockchainImpl.java

@@ -209,11 +223,6 @@ public BlockchainImpl withAdminInfo(AdminInfo adminInfo) {
        return this;
    }

-    public BlockchainImpl withEthereumListener(EthereumListener listener) {


Listener doesn't look the thing which is required for running BlockchainImpl. Also old constructor could be used by somebody. I'd prefer to keep both old constructor (and init listener there with EthereumListener.EMPTY) and withEthereumListener method.

zilm13 · 2018-09-20T21:36:24Z

ethereumj-core/src/main/java/org/ethereum/manager/WorldManager.java

    public void addListener(EthereumListener listener) {
        logger.info("Ethereum listener added");
-        ((CompositeEthereumListener) this.listener).addListener(listener);
+        ((BackwardCompatibilityEthereumListenerProxy) listener).getCompositeListener().addListener(listener);


If user have used our listener in most common way (ethereum.addListener(new EthereumListenerAdapter(){})) he will get strange exception here, I guess.

Why do you think so ? This code fully support old logic.

Users have code like
ethereum.addListener(new EthereumListenerAdapter());
after that it goes:
->
worldManager.addListener(listener)
->
((BackwardCompatibilityEthereumListenerProxy) EthereumListenerAdapter instance)

zilm13 · 2018-09-20T21:43:32Z

ethereumj-core/src/main/java/org/ethereum/publish/event/Events.java

+import org.ethereum.publish.event.message.MessageSent;
+import org.ethereum.publish.event.message.PeerHandshaked;
+
+public final class Events {


Does this class made for internal purposes of compatibility?

Nope, this class added for using convenience. For instance using
publisher.publish(onSyncDone(SOME_STATUS)) more readable than publisher.publish(new SyncDone(SOME_STATUS)).

zilm13 · 2018-09-20T21:50:39Z

ethereumj-core/src/main/java/org/ethereum/facade/Ethereum.java

+     * @see Publisher
+     * @see Event
+     */
+    Publisher subscribe(Subscription subscription);


We should add some handy links where user could see available type of Events. Current user entrance could stuck without samples.

zilm13 · 2018-09-20T21:54:26Z

ethereumj-core/src/main/java/org/ethereum/net/eth/handler/EthHandler.java

@@ -99,6 +104,10 @@ public void channelRead0(final ChannelHandlerContext ctx, EthMessage msg) throws
        msgQueue.receivedMessage(msg);
    }

+    public Publisher getPublisher() {
+        return ((BackwardCompatibilityEthereumListenerProxy) ethereumListener).getPublisher();


I think BackwardCompatibilityEthereumListenerProxy should be localized somehow and don't spread to such classes.

The main idea of BackwardCompatibilityEthereumListenerProxy is to encapsulate new and old publishing mechanisms under EthereumListener interface, and proxy old messages to both of them with / without transformation. We should use this component everywhere to reduce the number of changes and support both mechanisms at the same time.
BackwardCompatibilityEthereumListenerProxy will simplify removing deprecated logic in the future. And when the time comes we'll remove BackwardCompatibilityEthereumListenerProxy and all EthereumListener related stuff and leave only Publisher invokes.

I got this idea as we are moving everything inside our application to the new subscribe-publish model, while leaving common user interfaces and marking them as deprecated. So any backward compatibility gateways should be localized to old public user interfaces.

zilm13 · 2018-09-21T08:34:54Z

ethereumj-core/src/main/java/org/ethereum/samples/EventListenerSample.java

-            }
-        });
+        // when block arrives look for our included transactions
+        ethereum.subscribe(to(BlockAdded.class, this::onBlock));


I see old method usage in private void replayOnly() throws Exception
ethereum.addListener(blockReplay);

zilm13 · 2018-09-21T08:51:21Z

...umj-core/src/main/java/org/ethereum/listener/BackwardCompatibilityEthereumListenerProxy.java

+    }
+
+    @Override
+    public void trace(String output) {


why this kind of event was not added to publisher-subscriber implementation?

Cause we don't want to support it anymore

mkalinin · 2018-09-27T10:16:33Z

...umj-core/src/main/java/org/ethereum/listener/BackwardCompatibilityEthereumListenerProxy.java

+    @Override
+    public void onBlock(BlockSummary blockSummary) {
+        compositeListener.onBlock(blockSummary);
+        publisher.publish(Events.onBlockAdded(blockSummary));


In a new pub/sub there should not be a version of onBlockAdded() which doesn't accept best class. Treat it as a deprecated feature

Still requesting to remove Events.onBlockAdded(blockSummary) shortcut and corresponding event from new pub/sub.

mkalinin · 2018-09-27T10:35:20Z

ethereumj-core/src/main/java/org/ethereum/publish/event/SyncDone.java

+
+public class SyncDone extends Event<SyncDone.State> implements OneOffEvent {
+
+    public enum State {


I propose moving this enum to SyncManager class or create a standalone enum in sync package

mkalinin · 2018-09-27T10:36:06Z

ethereumj-core/src/main/java/org/ethereum/publish/event/PendingTransactionUpdated.java

+ */
+public class PendingTransactionUpdated extends Event<PendingTransactionUpdated.Data> {
+
+    public enum State {


Let's move it to PendingTransaction class

mkalinin · 2018-09-27T10:48:12Z

ethereumj-core/src/main/java/org/ethereum/publish/Subscription.java

+            this.subscription = subscription;
+        }
+
+        public void unsubscribe() {


There is a lack of description that points to potential use cases.

still not added :)

mkalinin · 2018-09-27T11:20:13Z

ethereumj-core/src/main/java/org/ethereum/facade/Ethereum.java

+    /**
+     * More convenient version of {@link #subscribe(Subscription)}
+     */
+    <T> Publisher subscribe(Class<? extends Event<T>> type, BiConsumer<T, Subscription.LifeCycle> handler);


I think Publisher class should also have such shortcuts

To increase UX we may create shortcuts for event classes and put them together into one place.
For example, use Event or create new EventType class and add a list of event types definition with readable names:
public static final Class<? extends Event<BlockAdded.Data>> BLOCK_ADDED = BlockAdded.class;
Then point this type aggregation class in javadocs. It would work like an event picker then and make user choice faster, user will have to type Event. to get a list of available options

…couple bugs. Refactors samples.

mkalinin · 2018-10-08T13:54:45Z

ethereumj-core/src/main/java/org/ethereum/db/DbFlushManager.java

@@ -44,7 +51,7 @@

    List<AbstractCachedSource<byte[], ?>> writeCaches = new CopyOnWriteArrayList<>();
    List<Source<byte[], ?>> sources = new CopyOnWriteArrayList<>();
-    Set<DbSource> dbSources = new HashSet<>();
+    Set<DbSource> dbSources ;


As for me there is no reason for this change.

I'll revert this change

mkalinin · 2018-10-08T13:56:03Z

ethereumj-core/src/main/java/org/ethereum/facade/EthereumImpl.java

        gLogger.info("EthereumJ node started: enode://" + toHexString(config.nodeId()) + "@" + config.externalIp() + ":" + config.listenPort());
    }

+    @PostConstruct
+    public void init() {
+        worldManager.subscribe(to(BLOCK_ADED, data -> gasPriceTracker.onBlock(data.getBlockSummary())));


BLOCK_ADED => BLOCK_ADDED

I'll fix it

mkalinin · 2018-10-08T13:57:02Z

...umj-core/src/main/java/org/ethereum/listener/BackwardCompatibilityEthereumListenerProxy.java

+    }
+
+    @Override
+    public void trace(String output) {


Cause we don't want to support it anymore

mkalinin · 2018-10-08T13:58:26Z

...umj-core/src/main/java/org/ethereum/listener/BackwardCompatibilityEthereumListenerProxy.java

+    @Override
+    public void onBlock(BlockSummary blockSummary) {
+        compositeListener.onBlock(blockSummary);
+        publisher.publish(Events.onBlockAdded(blockSummary));


Still requesting to remove Events.onBlockAdded(blockSummary) shortcut and corresponding event from new pub/sub.

mkalinin · 2018-10-08T14:01:29Z

ethereumj-core/src/main/java/org/ethereum/listener/BlockReplayer.java

+ * <p>
+ * Created by Eugene Shevchenko on 07.10.2018.
+ */
+public class BlockReplayer {


Should we mark its predecessor BlockReplay class as a deprecated one?

yep, I'll add comment.

mkalinin · 2018-10-08T14:06:01Z

ethereumj-core/src/main/java/org/ethereum/publish/Subscription.java

+            this.subscription = subscription;
+        }
+
+        public void unsubscribe() {


still not added :)

e.shevchenko added 6 commits August 9, 2018 01:58

Replaces CompositeEthereumListener with new pub/sub model implementat…

27c10b1

…ion.

Removes (almost) EthereumListenerAdaptor using

8165a2c

Adds unsubscribeAfter(event) logic

53e0173

Makes Publisher dependant from abstract executor. Adds additional log…

d2fd027

…ging.

Merge branch 'develop' into feature/1138-event-listener-improve

80fe9f8

Replace EthereumListener to Publisher usage

7a27d8d

eugene-shevchenko requested review from mkalinin and zilm13 August 10, 2018 20:18

eugene-shevchenko assigned eugene-shevchenko, mkalinin and zilm13 Aug 10, 2018

mkalinin added this to the 1.9.0-Constantinople milestone Aug 12, 2018

mkalinin suggested changes Aug 13, 2018

View reviewed changes

e.shevchenko added 3 commits August 14, 2018 13:45

Merge branch 'develop' into feature/1138-event-listener-improve

350c5d1

Renames all events by removing 'Event' suffix.

c216d32

Removes experimental publisher

9627991

e.shevchenko added 3 commits August 14, 2018 15:11

Adds backward compatibility EthereumListener proxy component.

86e7ca4

Migrate to backeard compatibility EthereumListener using.

c54d4b9

Deletes unused events + some events rename.

acb5e89

zilm13 reviewed Aug 14, 2018

View reviewed changes

e.shevchenko added 7 commits August 15, 2018 17:40

Removes import wilcards.

06c7022

Adds one-off condition to subscription.

f643b3c

Adds subscription with life cycle abstraction.

5fcd91f

Reverts formattings changes.

7fc9119

Merge branch 'develop' into feature/1138-event-listener-improve

e1f739c

Adds concurrency testing.

2e07934

Merge branch 'develop' into feature/1138-event-listener-improve

7bf20ff

mkalinin suggested changes Aug 22, 2018

View reviewed changes

e.shevchenko added 2 commits August 22, 2018 20:40

Moves LifeCycle to Subscription.

e41e31b

Replaces EthereumListener.STUB anonymous class with EthereumListenerA…

ab4754d

…dapter instance.

eugene-shevchenko commented Aug 22, 2018

View reviewed changes

ethereum deleted a comment from mkalinin Aug 22, 2018

e.shevchenko added 6 commits August 22, 2018 21:58

Adds more convenient subscribing methods to Ethereum interface.

b214302

Reverts RecommendedGasPriceTracker

003ae12

Adds copyright headers.

7288636

Merge branch 'develop' into feature/1138-event-listener-improve

442046b

Merge branch 'develop' into feature/1138-event-listener-improve

a06646a

Clones deprecated EthereumListener's state enums for Publisher events.

698b59a

zilm13 reviewed Sep 20, 2018

View reviewed changes

zilm13 reviewed Sep 21, 2018

View reviewed changes

e.shevchenko added 3 commits September 21, 2018 13:21

Merge branch 'develop' into feature/1138-event-listener-improve

feeff0c

Merge branch 'develop' into feature/1138-event-listener-improve

d463bd1

Fixes 'this' reference error.

0d61180

mkalinin suggested changes Sep 27, 2018

View reviewed changes

e.shevchenko added 2 commits October 8, 2018 12:06

Adds extra shortcuts to Publisher. Adds Events.Type constants. Fixes …

00d4609

…couple bugs. Refactors samples.

Develop merge

3bd0f73

mkalinin modified the milestones: 1.9.0-Constantinople, 1.10.0 Oct 8, 2018

mkalinin suggested changes Oct 8, 2018

View reviewed changes

e.shevchenko added 4 commits October 8, 2018 17:12

Fixes typo.

67e9c6a

Adds minor fixes

d576607

Adds several comments/

f0bf19a

Adds copyright headers.

7ee5811

mkalinin modified the milestones: 1.10.0, 1.11.0 Jan 11, 2019


		import org.ethereum.core.BlockSummary;

		public class BlockAddedEvent extends Event<BlockSummary> {

		@@ -0,0 +1,4 @@
		package org.ethereum.publish.event;

		public class NoConnectionsEvent extends SignalEvent {


		import org.ethereum.core.BlockSummary;

		public class BestBlockAddedEvent extends Event<BestBlockAddedEvent.Data> {


		import static java.util.Objects.isNull;

		public class EventBus {

		private final List<EthereumListener> listeners;


		public CompositeEthereumListener(Executor executor) {


		public class SyncDone extends Event<SyncDone.State> implements OneOffEvent {

		public enum State {

Improve EthereumListener #1152

Are you sure you want to change the base?

Improve EthereumListener #1152

Conversation

eugene-shevchenko commented Aug 10, 2018

mkalinin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Aug 14, 2018 • edited Loading

Choose a reason for hiding this comment

mkalinin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eugene-shevchenko Aug 22, 2018 • edited Loading

Choose a reason for hiding this comment

eugene-shevchenko Aug 22, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Aug 14, 2018 •

edited

Loading

eugene-shevchenko Aug 22, 2018 •

edited

Loading

eugene-shevchenko Aug 22, 2018 •

edited

Loading