Starting to reformat loops into a unified concept #2773

manumafe98 · 2024-04-04T19:05:53Z

pull request

This PR reworks our current loop structure (for and for-each) into one big single concept called loops and also introduces while and do-while loops

closes #2625

Reviewer Resources:

Track Policies

Adding reference resolution Making small updates to instructions Adding blueprint to give to students

…itespace to config.json

sanderploegsma · 2024-04-13T12:27:49Z

I'm aiming to review this early next week, FYI 😉

concepts/loops/about.md

concepts/loops/introduction.md

exercises/concept/making-the-grade/.meta/config.json

exercises/concept/making-the-grade/.docs/hints.md

exercises/concept/making-the-grade/.docs/instructions.md

sanderploegsma · 2024-04-26T18:47:56Z

exercises/concept/making-the-grade/.meta/design.md

+
+## Out of scope
+
+- Specific iteration over a `Map`


Why is this listed here? When I think about loops I don't necessarily think of maps.

Things that are related and seem to be out of scope of this exercise:

Breaking out of loops using the break keyword

Skipping iterations using the continue keyword

Instead of adding those to the out of scope I prefer mention them and maybe try to add exercise to cover those topics now that you say it, do you have in mind some other topics that could be out of scope? or I should remove it?

I'd be worried that also adding the control-flow statements to this exercise may make it a bit too big.

6 tasks in a not very complex concept for me seems acceptable

concepts/loops/about.md

Co-authored-by: Sander Ploegsma <[email protected]>

…pics were introduced Adding links to the corresponding headings topics

Adding a different introduction instead of copying the about.md Adding continue and break statements explanation and exercises

concepts/loops/about.md

sanderploegsma · 2024-05-07T06:55:53Z

concepts/loops/introduction.md

Whoa, I know I said to trim down the contents of the introduction but I think we need to give at least some information 😂

🤣 What do you suggest to add then ? hahaha

sanderploegsma · 2024-05-07T06:57:48Z

config.json

-          "arrays",
-          "for-loops",
-          "foreach-loops"
+          "arrays"


Maybe, I don't know to be honest. That would mean that the exercise is limited to just array creation and array indexing?

I'd like to have a good plan going forward, discussions like these become a bit too big for code reviews tbh.

sanderploegsma · 2024-05-07T06:59:10Z

exercises/concept/making-the-grade/.meta/design.md

+
+## Out of scope
+
+- Specific iteration over a `Map`


I'd be worried that also adding the control-flow statements to this exercise may make it a bit too big.

sanderploegsma · 2024-05-07T07:07:37Z

exercises/concept/making-the-grade/.meta/src/reference/java/MakingTheGrade.java

+    static int evaluateChallengingExam(List<Integer> studentScores) {
+        int count = 0;
+
+        for (int score : studentScores) {
+            if (score <= 40) {
+                break;
+            }
+
+            count++;
+        }
+
+        return count;


This actually makes for a nice while task:

class MakingTheGrade { static int evaluateChallengingExam(List<Integer> studentScores) { int index = 0; while (studentScores.get(index) > 40) { index++; } return index + 1; } }

😆

Do you suggest to change this one for the one that is actually the while task? and make a new one for break ?

Floating another idea for trying to keep this as a break task, it might help to require them to something a bit more with the matching score. For example, if we require them to add the score to a second list (like keeping a list of the first failing score), the solution might look like this:

static void evaluateChallengingExam(List<Integer> studentScores, List<Integer> firstFailingScores) { for (int score : studentScores) { if (score <= 40) { firstFailingScores.add(score); break; } } }

This way, we can even come up with tests for when the none of the scores pass.

exercises/concept/making-the-grade/src/test/java/MakingTheGradeTest.java

Co-authored-by: Sander Ploegsma <[email protected]>

…l statements section Adding two tests for task 5 and 6 Updating design.md to remove out of scope and add new missing learning objective

…java into ReformatLoopsConcept

manumafe98 · 2024-07-11T23:36:01Z

Hey @kahgoh Do you mind helping me review this PR? Sander is taking a break from exercism so I will like your opinions on this topics

kahgoh · 2024-07-12T06:38:22Z

Hey @manumafe98, I'd be happy to help :) I hope to have a look at it within a day or two.

manumafe98 · 2024-07-12T15:54:25Z

Hey @manumafe98, I'd be happy to help :) I hope to have a look at it within a day or two.

Thanks! no rush

kahgoh · 2024-07-14T06:13:16Z

exercises/concept/making-the-grade/.meta/src/reference/java/MakingTheGrade.java

+
+        for (int score : studentScores) {
+            if (score % 2 == 0) {
+                continue;


I notice the design says to have an essential comment if the student doesn't use continue. I think another valid way to solve this one is to add only odd scores in an if statements (i.e. no usage of continue):

static int countOddScores(List<Integer> studentScores) { int count = 0; for (int score : studentScores) { if (score % 2 != 0) { count++; } } }

We could try to make up a more complicated calculation (although, haven't thought how it could fit with the story yet). For example, we could try something like:

Lets say we are trying to calculate a value. The value starts at 0. Then for each score ...

If the number is even, go to the next number (don't do anything to value).

Then, if the number is also greater than 20, add 5 to value.

Then, if the number is also greater than 60, then double the value.

Then, if the number is also greater than 80, subtract 50 from value.

We could even add something like "stop adding to the value if the number is greater than 90" to sneak in a possible break.

kahgoh · 2024-07-14T06:34:54Z

exercises/concept/making-the-grade/.meta/src/reference/java/MakingTheGrade.java

+        while (count < numberOfStudents) {
+            sum += studentScores.get(count);
+            count++;
+        }


I think I would also likely use the for loop too (as per @sanderploegsma's comment). Giving them a list to go through "opens the door" for the for loop. Perhaps we could try moving away from a list - we could try ask them to call a method that returns something until a condition is met.

One way that came to my mind is that we could extend the challenging exam scenario by saying we want to see how many attempts it takes for a student to pass on exam. Then we could give them an Attempt object with a score() method that returns different a value each time it is called.

kahgoh · 2024-07-14T09:14:07Z

exercises/concept/making-the-grade/.meta/src/reference/java/MakingTheGrade.java

+    static int evaluateChallengingExam(List<Integer> studentScores) {
+        int count = 0;
+
+        for (int score : studentScores) {
+            if (score <= 40) {
+                break;
+            }
+
+            count++;
+        }
+
+        return count;


Floating another idea for trying to keep this as a break task, it might help to require them to something a bit more with the matching score. For example, if we require them to add the score to a second list (like keeping a list of the first failing score), the solution might look like this:

static void evaluateChallengingExam(List<Integer> studentScores, List<Integer> firstFailingScores) { for (int score : studentScores) { if (score <= 40) { firstFailingScores.add(score); break; } } }

This way, we can even come up with tests for when the none of the scores pass.

exercises/concept/making-the-grade/.docs/instructions.md

Co-authored-by: Kah Goh <[email protected]>

josealonso · 2024-12-28T01:27:36Z

@manumafe98, @kahgoh, happy to work with you on this one, guys.

Starting to reformat loops into a unified concept

c9525b4

manumafe98 added the x:size/large Large amount of work label Apr 4, 2024

manumafe98 self-assigned this Apr 4, 2024

manumafe98 marked this pull request as draft April 4, 2024 19:05

manumafe98 and others added 5 commits April 5, 2024 13:20

Adding instructions for the exercise and structure of the concept

2bfe185

Adding design.md content

d4cc8c5

Adding reference resolution Making small updates to instructions Adding blueprint to give to students

Adding hints, tests and updating reference resolution to fix some issues

799fa60

Merge branch 'exercism:main' into ReformatLoopsConcept

9ce9240

Fixing checkstyle error, adding gradle wrappers and adding missing wh…

c562a88

…itespace to config.json

manumafe98 marked this pull request as ready for review April 5, 2024 20:41

manumafe98 requested a review from sanderploegsma April 5, 2024 20:41

sanderploegsma requested changes Apr 26, 2024

View reviewed changes

manumafe98 and others added 6 commits April 26, 2024 17:28

Update exercises/concept/making-the-grade/.docs/hints.md

6d6c4bb

Co-authored-by: Sander Ploegsma <[email protected]>

Update concepts/loops/about.md

1050cbc

Co-authored-by: Sander Ploegsma <[email protected]>

Update exercises/concept/making-the-grade/.meta/config.json

5f81a4f

Co-authored-by: Sander Ploegsma <[email protected]>

Update exercises/concept/making-the-grade/.docs/instructions.md

4020fde

Co-authored-by: Sander Ploegsma <[email protected]>

Re ordering the topic presentation sentence to match the order the to…

7f0a64d

…pics were introduced Adding links to the corresponding headings topics

Updating for loop introduction

5c89605

Adding a different introduction instead of copying the about.md Adding continue and break statements explanation and exercises

manumafe98 requested a review from sanderploegsma April 28, 2024 22:14

manumafe98 mentioned this pull request May 7, 2024

Add Game of Life exercise #2793

Merged

sanderploegsma reviewed May 7, 2024

View reviewed changes

manumafe98 and others added 3 commits May 7, 2024 12:03

Update concepts/loops/about.md

f072854

Co-authored-by: Sander Ploegsma <[email protected]>

Updating about.md to make break and continue be under the Loop contro…

f31c25c

…l statements section Adding two tests for task 5 and 6 Updating design.md to remove out of scope and add new missing learning objective

Merge branch 'ReformatLoopsConcept' of https://github.com/manumafe98/…

02653ea

…java into ReformatLoopsConcept

kahgoh reviewed Jul 14, 2024

View reviewed changes

Update exercises/concept/making-the-grade/.docs/instructions.md

d24c6c0

Co-authored-by: Kah Goh <[email protected]>

Deleting trailing spaces

4085a81

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Starting to reformat loops into a unified concept #2773

Starting to reformat loops into a unified concept #2773

manumafe98 commented Apr 4, 2024 •

edited

Loading

sanderploegsma commented Apr 13, 2024

sanderploegsma Apr 26, 2024

manumafe98 Apr 26, 2024

sanderploegsma May 7, 2024

manumafe98 May 7, 2024

sanderploegsma May 7, 2024

manumafe98 May 7, 2024

sanderploegsma May 7, 2024

sanderploegsma May 7, 2024

sanderploegsma May 7, 2024

manumafe98 May 7, 2024

kahgoh Jul 14, 2024

manumafe98 commented Jul 11, 2024

kahgoh commented Jul 12, 2024 •

edited

Loading

manumafe98 commented Jul 12, 2024

kahgoh Jul 14, 2024 •

edited

Loading

kahgoh Jul 14, 2024

kahgoh Jul 14, 2024

josealonso commented Dec 28, 2024

Starting to reformat loops into a unified concept #2773

Are you sure you want to change the base?

Starting to reformat loops into a unified concept #2773

Conversation

manumafe98 commented Apr 4, 2024 • edited Loading

pull request

sanderploegsma commented Apr 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

manumafe98 commented Jul 11, 2024

kahgoh commented Jul 12, 2024 • edited Loading

manumafe98 commented Jul 12, 2024

kahgoh Jul 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josealonso commented Dec 28, 2024

manumafe98 commented Apr 4, 2024 •

edited

Loading

kahgoh commented Jul 12, 2024 •

edited

Loading

kahgoh Jul 14, 2024 •

edited

Loading