Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump libraries and enable the new architecture #7

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

cipolleschi
Copy link
Contributor

@cipolleschi cipolleschi commented Jun 21, 2024

This change bumps

  • react-native-screens
  • react-native-gesture-handlers

These were two libraries that were creating errors in the app when the New Architecture was turned on.
Sowftware Mansion released a new versions of the libraries with a fix.

So we are also enabling the new Architecture. 🎉

Test Plan

Tested locally and it works!

.vscode/settings.json Outdated Show resolved Hide resolved
@cipolleschi
Copy link
Contributor Author

The pr-preview job has failed because it couldn't create an EAS update. I think that it makes sense, given that we are bumping a couple of dependencies AND turning on the New Architecture, right?

@kadikraman
Copy link
Collaborator

@cipolleschi yep, we're all good to ignore the PR preview.

@cipolleschi
Copy link
Contributor Author

Can you merge this? 😄 it looks like I can't!

Screenshot 2024-06-25 at 15 35 56

@brentvatne brentvatne merged commit a83c459 into expo:main Jun 26, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants