Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.js #6145

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update index.js #6145

wants to merge 1 commit into from

Conversation

leeli0
Copy link

@leeli0 leeli0 commented Nov 5, 2024

Add remarks for wildcard parameters of Express 5.x

Add remarks for wildcard parameters of Express 5.x
@IamLizu
Copy link
Member

IamLizu commented Nov 5, 2024

Hi @UlisesGascon 👋

Did we have a plan to separate the examples from this repository?

@wesleytodd
Copy link
Member

wesleytodd commented Nov 5, 2024

Yes I believe that is the plan: #5309

For now though, I am not a big fan of a version specific comment like this. The master branch now is v5, so if you are interested in examples for express@4 then I would suggest we direct folks to the 4.x branch.

EDIT: oops, early send.

That said, the other part of this change is good imo.

@leeli0
Copy link
Author

leeli0 commented Nov 7, 2024

Directly runing the example in the repository environment is perfect. Nevertheless, if try the example in a project and the npm install express@4 as default would cause some inconvenience. Also, Route parameters of Express 5.x API doesn't metion the use of wildcard parameters, so for newbies like me might feel confusing of the '/files/*file' route path.

@wesleytodd
Copy link
Member

Hm, that's great feedback. I am not sure what the best way is to do this. Maybe we could make the comment "this changed in 5.0.0, see our migration guide (link) for more details"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants