-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support more actions in JSON schema conversion #998
base: main
Are you sure you want to change the base?
Conversation
7d32cf3
to
a931fd2
Compare
Adds support for the following actions in JSON schema conversion: - `bic` - `cuid2` - `decimal` - `digits` - `empty`
a931fd2
to
274c950
Compare
I first need to check that the |
no worries you are right that the flags will be lost during conversion. not a lot to be done about that we could throw/skip if any flags are set, or we could accept that the conversion is lossy |
I am not sure how to proceed. So far the only important flag we are using is |
I think we do both:
if it turns out this isn't possible (especially since we use we don't support any of them yet, so throwing seems to make more sense than "best effort" |
I think we can ignore the I will look into rewriting some or all of the regular expressions. However, our v1 RC release has a higher priority. So it may be a while before we can move forward with this PR. |
Perhaps we can translate the |
Adds support for the following actions in JSON schema conversion:
bic
cuid2
decimal
digits
empty