-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 16K host page support #4916
Open
ShadowCurse
wants to merge
4
commits into
firecracker-microvm:main
Choose a base branch
from
ShadowCurse:net_iov_16K_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+78
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4916 +/- ##
==========================================
- Coverage 83.93% 83.93% -0.01%
==========================================
Files 248 248
Lines 27791 27814 +23
==========================================
+ Hits 23327 23345 +18
- Misses 4464 4469 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
2 times, most recently
from
November 15, 2024 13:55
2f523ef
to
a879102
Compare
ShadowCurse
requested review from
bchalios and
roypat
and removed request for
bchalios
November 15, 2024 14:33
ShadowCurse
added
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Type: Fix
Indicates a fix to existing code
labels
Nov 15, 2024
pb8o
reviewed
Nov 15, 2024
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
from
November 15, 2024 15:08
a879102
to
82a4d30
Compare
kalyazin
reviewed
Nov 15, 2024
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
5 times, most recently
from
November 21, 2024 15:47
a10e8bb
to
c8f2643
Compare
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
3 times, most recently
from
November 26, 2024 09:36
9c4e018
to
b86cdc7
Compare
kalyazin
reviewed
Nov 26, 2024
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
3 times, most recently
from
November 27, 2024 19:01
173d4b6
to
2b43582
Compare
kalyazin
previously approved these changes
Nov 28, 2024
roypat
reviewed
Nov 28, 2024
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
4 times, most recently
from
November 29, 2024 10:21
b4c65dd
to
661d027
Compare
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
4 times, most recently
from
December 11, 2024 17:23
9f67b77
to
d51aca0
Compare
ShadowCurse
added
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
and removed
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
labels
Dec 11, 2024
roypat
approved these changes
Dec 11, 2024
kalyazin
approved these changes
Dec 23, 2024
Firecracker was assuming page sizes for both host and guest are 4K. But they can differ, so split into 2 values. Signed-off-by: Egor Lazarchuk <[email protected]>
Define global variable with host page size and update it at the very beginning of the main function in Firecracker. This way data types which rely on specific host page size can adapt to it. Signed-off-by: Egor Lazarchuk <[email protected]>
Remove restriction on size and host page size. Signed-off-by: Egor Lazarchuk <[email protected]>
Add note about making `IovDeque` to work with any host page size. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
from
December 23, 2024 14:26
44b4ab1
to
ad8d232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Status: Awaiting review
Indicates that a pull request is ready to be reviewed
Type: Fix
Indicates a fix to existing code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Separate
PAGE_SIZE
constant into 2:GUEST_PAGE_SIZE
andHOST_PAGE_SIZE
.HOST_PAGE_SIZE
has a default of 4K, but is also queried at runtime to support other page sizes.The only structure which did not work with non default 4K pages is
IovDeque
. This PR updates itand removes restrictions on the queue size and on the host page size.
Tested16K pages support on rp5 with 16K page kernel.
Reason
Previously Firecracker was working on hosts with non 4K pages, but with 1.10 version we introduced
IovDeque
typewhich assumed the host page size to be 4K.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
tools/devtool checkstyle
to verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md
.Runbook for Firecracker API changes.
integration tests.
TODO
.rust-vmm
.