Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync commits from upstream #3

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Conversation

lcduong
Copy link
Contributor

@lcduong lcduong commented Oct 23, 2024

Commit hash Description
5024d419805c24ea180629037ecd9c4bd6b19692 Release v1.5.0
f83856a71f5c83e46b1ed2e4202e37a06edf918a Update translations
50160ab31bbf74138a386a43c796dcd0fa5d8a47 Improve error display
44709a8195590b60b45d4066d8b4c29b0d60ffc4 Use new widget
50e1428a63ba2d1f3798732d73192346bc212401 Fix form error rendering
d0311871e0f7ef11696533bde053b2537a33fce9 Remove django-bootstrap4
e219185c43852d9388f393dbf689bc2fd4ffc524 Use modern widgets
2db7aaff2615aa673ededebe5ab7b4f9d3a9dcf4 Don't pin dep, play nice with other plugins
fcdf0da5f9523fcd1bb5a141caad587694b59322 Oops, use correct dependency
9738fc47a17758845f45d7e3d6679e6195ff0de7 Add missing JWT dependency
be9db1b01b7c25ffe4651baa3a5f4c330578a847 Release v1.4.0

Summary by Sourcery

Sync with upstream changes, updating the version to 1.5.0, and refactor the settings template to use modern widgets and remove the django-bootstrap4 dependency. Fix form error rendering by using a common error template.

New Features:

  • Introduce new widget usage in the settings template.

Bug Fixes:

  • Fix form error rendering by including a common error template.

Enhancements:

  • Replace bootstrap form fields with modern widget field groups in the settings template.
  • Remove django-bootstrap4 dependency and update form widgets to use modern alternatives.

Chores:

  • Sync commits from upstream repository, including version updates and dependency adjustments.

Copy link

sourcery-ai bot commented Oct 23, 2024

Reviewer's Guide by Sourcery

This pull request syncs commits from upstream, updating the project from version 1.3.0 to 1.5.0. The changes include updating translations, improving error display, using new widgets, fixing form error rendering, and removing the django-bootstrap4 dependency. The main focus is on modernizing the UI components and improving the overall user experience.

User journey diagram for updated form rendering

journey
    title Updated Form Rendering
    section Form Submission
      User: Clicks submit button: 5: Old
      System: Displays form errors using bootstrap4: 3: Old
      System: Displays form errors using common/forms/errors.html: 5: New
    section Form Fields
      User: Fills out form fields: 5: Old
      System: Renders fields with bootstrap_field: 3: Old
      System: Renders fields with as_field_group: 5: New
Loading

Updated class diagram for form widgets

classDiagram
    class Form {
        +String url
        +String token
        +String return_url
        +String show_join_link
        +String join_url
        +String secret
        +String issuer
        +String audience
        +String join_start
        +String join_text
    }
    class HtmlDateTimeInput
    class DateTimeInput
    Form --> HtmlDateTimeInput : join_start
    Form ..> DateTimeInput : replaced by
Loading

File-Level Changes

Change Details Files
Update version number
  • Bump version from 1.3.0 to 1.5.0
pretalx_venueless/__init__.py
Remove django-bootstrap4 dependency
  • Remove {% load bootstrap4 %} tag
  • Replace {% bootstrap_form_errors form %} with {% include "common/forms/errors.html" %}
  • Replace {% bootstrap_field %} with {{ form.field.as_field_group }}
pretalx_venueless/templates/pretalx_venueless/settings.html
Update form widgets
  • Replace DateTimeInput widget with HtmlDateTimeInput
  • Remove moment.js and datetimepicker scripts
pretalx_venueless/templates/pretalx_venueless/settings.html
pretalx_venueless/forms.py
Clean up template structure
  • Remove unnecessary whitespace and newlines
  • Reorganize template blocks for better readability
pretalx_venueless/templates/pretalx_venueless/settings.html

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lcduong - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@mariobehling mariobehling merged commit d6477c8 into fossasia:main Oct 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants