-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync commits from upstream #3
Conversation
Reviewer's Guide by SourceryThis pull request syncs commits from upstream, updating the project from version 1.3.0 to 1.5.0. The changes include updating translations, improving error display, using new widgets, fixing form error rendering, and removing the django-bootstrap4 dependency. The main focus is on modernizing the UI components and improving the overall user experience. User journey diagram for updated form renderingjourney
title Updated Form Rendering
section Form Submission
User: Clicks submit button: 5: Old
System: Displays form errors using bootstrap4: 3: Old
System: Displays form errors using common/forms/errors.html: 5: New
section Form Fields
User: Fills out form fields: 5: Old
System: Renders fields with bootstrap_field: 3: Old
System: Renders fields with as_field_group: 5: New
Updated class diagram for form widgetsclassDiagram
class Form {
+String url
+String token
+String return_url
+String show_join_link
+String join_url
+String secret
+String issuer
+String audience
+String join_start
+String join_text
}
class HtmlDateTimeInput
class DateTimeInput
Form --> HtmlDateTimeInput : join_start
Form ..> DateTimeInput : replaced by
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lcduong - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Summary by Sourcery
Sync with upstream changes, updating the version to 1.5.0, and refactor the settings template to use modern widgets and remove the django-bootstrap4 dependency. Fix form error rendering by using a common error template.
New Features:
Bug Fixes:
Enhancements:
Chores: