Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize additional Dyalog APL file extensions #7085

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ararslan
Copy link
Contributor

@ararslan ararslan commented Oct 9, 2024

Description

Dyalog APL uses a variety of file extensions in addition to .apl and .dyalog. The others are for specific kinds of definitions:

  • .aplf for functions
  • .apln for namespaces
  • .aplc for classes
  • .aplo for operators
  • .apli for interfaces

At present, none of those extensions are recognized as APL by linguist; this PR adds them.

Checklist:

@ararslan ararslan requested a review from a team as a code owner October 9, 2024 20:09
@lildude
Copy link
Member

lildude commented Oct 10, 2024

This PR will be held back until all of the extensions you are adding each meet our usage requirements.

Rather than keeping this hanging around potentially forever, I recommend adding only those that meet our requirements. Users can always use an override for the others until usage is sufficient to be added.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my other comment, real world samples are needed for all extensions being added. See CONTRIBUTING.md.

It's also worth ensuring that the current grammar will actually highlight these files correctly too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants