Fix code scanning alert no. 2: Prototype-polluting function #694
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/github/safe-settings/security/code-scanning/2
To fix the prototype pollution vulnerability, we need to ensure that properties like
__proto__
andconstructor
are not copied from thesource
object to themodifications
object. This can be achieved by adding a check to skip these properties during the merge process.__proto__
andconstructor
properties in thefor...in
loop that iterates oversource
.compareDeep
method of theMergeDeep
class in thelib/mergeDeep.js
file.Suggested fixes powered by Copilot Autofix. Review carefully before merging.