support linux-loong64 native debug #3685

yelvens · 2024-03-12T09:15:10Z

LoongArch is a new RISC ISA, which is independently designed by Loongson Technology.

LoongArch includes a reduced 32-bit version (LA32R), a standard 32-bit version (LA32S) and a 64-bit version (LA64), and loong64 is the 64-bit version of LoongArch.

LoongArch documentation: https://github.com/loongson/LoongArch-Documentation.git

Since version 1.19, golang upstream support for the LA architecture has been maintained.

yelvens · 2024-03-12T09:27:05Z

The arch project hasn't been integrated into the upstream yet, so I duplicated it to the vendor and submitted it.

aarzilli

Just dumping a bunch of changes in vendor that don't exist upstream is unacceptable, the x/arch changes need to be merged there first.

pkg/gobuild/gobuild.go

pkg/proc/native/support_sentinel_linux.go

aarzilli · 2024-03-12T11:25:04Z

PS. also see test failures.

pkg/proc/native/ptrace_linux_64bit.go

derekparker · 2024-04-19T15:50:13Z

@ihuang77 any updates on this based on @aarzilli feedback?

yelvens · 2024-04-23T03:09:43Z

Hi @aarzilli @derekparker

The x/arch has submitted a PR to support loong64, but it has not yet been merged into the upstream repository.

I can provide machines running CI at any time.

Thanks.

aarzilli · 2024-04-23T05:10:35Z

That's cool, we'll have to wait for that PR to be merged for this.

derekparker · 2024-10-03T21:05:58Z

Hi @aarzilli @derekparker

The x/arch has submitted a PR to support loong64, but it has not yet been merged into the upstream repository.

I can provide machines running CI at any time.

Thanks.

Looks like this has merged. Are you available to pick this work back up?

abner-chenc · 2024-10-04T14:56:50Z

@ihuang77 any updates on this based on @aarzilli feedback?

Yes, the x/arch has been implemented and we are ready to update the Pr as soon as possible. We can also provide CI machines at any time.

yelvens · 2024-10-09T06:34:40Z

Looks like this has merged. Are you available to pick this work back up?

Hi @derekparker @derekparker
The PR I submitted in x/arch has been merged. I just updated the PR I submitted here, and I would appreciate it if you could review the updated code. Thank you for your hard work.

abner-chenc

go get -u golang.org/x/arch@master --> go get -u golang.org/x/[email protected]

yelvens · 2024-10-09T07:17:01Z

go get -u golang.org/x/arch@master --> go get -u golang.org/x/[email protected]

Thank you. I have completed that task and have created a new PR specifically for submitting the arch update.

yelvens · 2024-10-11T08:11:09Z

Hi @aarzilli @derekparker
As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

aarzilli · 2024-10-11T12:15:18Z

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures).

abner-chenc · 2024-10-25T11:35:56Z

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures).
Hi, the loong64 machine and agent are ready, but before executing bin/agent.sh start, some configurations should be modified in conf/buildAgent.properties, such as what is the serverUrl value?

aarzilli · 2024-10-25T11:49:59Z

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures).
Hi, the loong64 machine and agent are ready, but before executing bin/agent.sh start, some configurations should be modified in conf/buildAgent.properties, such as what is the serverUrl value?

Yes, see: https://www.jetbrains.com/help/teamcity/configure-agent-installation.html I have never installed an agent myself so I can not provide any specific guidance there.
Also, note the merge conflicts and test failures.

abner-chenc · 2024-10-28T10:18:50Z

Hi @aarzilli @derekparker As I mentioned earlier:

I can provide machines running CI at any time.

The machines are always ready. If possible, could you kindly provide the runners configured as needed? Thank you.

You can download the agent from https://delve.teamcity.com/agents/overview (also note that there currently are test failures).
Hi, the loong64 machine and agent are ready, but before executing bin/agent.sh start, some configurations should be modified in conf/buildAgent.properties, such as what is the serverUrl value?

Yes, see: https://www.jetbrains.com/help/teamcity/configure-agent-installation.html I have never installed an agent myself so I can not provide any specific guidance there. Also, note the merge conflicts and test failures.

I read the instructions here, but there are no detailed steps. I still don't know how to deal with it. I configured serverUrl=https://delve.teamcity.com/app/dsl-plugins-repository and started the agent, but an error occurred.

pkg/dwarf/regnum/loong64.go

yelvens · 2024-11-26T08:22:21Z

@aarzilli @derekparker @abner-chenc

I'm sorry that I haven't worked here for a long time because I've been working on other things recently. I modified the build and test failures today and pushed the code here. Please review the code when your time permits. Thank you.

service/debugger/debugger_test.go

service/debugger/debugger_unix_test.go

pkg/proc/linutil/regs_loong64_arch.go

aarzilli

There are several merge conflicts.

pkg/gobuild/gobuild.go

pkg/proc/bininfo.go

aarzilli · 2024-11-28T14:54:45Z

pkg/proc/loong64_arch.go

+	}
+}
+
+func loong64FixFrameUnwindContext(fctxt *frame.FrameContext, pc uint64, bi *BinaryInfo) *frame.FrameContext {


For this function, and loong64SwitchStack I'd rather have them be empty than mindlessly copypasted from the amd64 version.

Thank you very much for patiently reviewing the code in this PR. Delve is a powerful, user-friendly, yet complex debugger. My knowledge in this area is relatively limited, and some parts of the implementation, such as loong64FixFrameUnwindContext, are not done well. However, I will continue to deepen my understanding in this area and work to improve it as soon as possible.

You marked this comment as resolved but did nothing.

@aarzilli

I modified the loong64SwitchStack function.
The loong64FixFrameUnwindContext function is implemented with reference to arm64 and based on the LoongArch specific DWARF definition.
As I said before, delve is a complex and powerful debugging tool. Although I am working hard to learn its related knowledge, there are still some blind spots in my knowledge. I hope you can point out my mistakes more specifically and I will correct them in time. Thank you very much.

The problem is: why is there anything at all here? This function is about stack unwinding with cgo and with exceptions, I see that many (all?) tests relating to this piece of code are disabled so why is this here at all? Why is this function not just empty? Is there any code here that actually works?

The same goes for loong64SwitchStack below. Is there anything besides the first if switch, in that function, that works? Can we delete all of it except the first if and the default branch of the first switch?

pkg/proc/loong64_arch.go

pkg/proc/loong64_disasm.go

pkg/proc/native/ptrace_linux_64bit.go

pkg/proc/native/registers_linux_loong64.go

pkg/proc/pe.go

pkg/proc/native/support_sentinel_linux.go

yelvens · 2024-12-09T10:38:03Z

@aarzilli Can you please take another look at this patch? Thanks a lot.

abner-chenc · 2024-12-20T12:00:50Z

Hi, @aarzilli Can this Pr be merged? When I use delve on different machines to debug Go programs on loong64 machines, I need to download this Pr to the local machine and compile it separately each time. I think if this Pr can be merged, I will have a better experience when using delve.

Thanks

aarzilli · 2024-12-29T08:46:27Z

pkg/proc/loong64_arch.go

+	}
+}
+
+func loong64FixFrameUnwindContext(fctxt *frame.FrameContext, pc uint64, bi *BinaryInfo) *frame.FrameContext {


The problem is: why is there anything at all here? This function is about stack unwinding with cgo and with exceptions, I see that many (all?) tests relating to this piece of code are disabled so why is this here at all? Why is this function not just empty? Is there any code here that actually works?

The same goes for loong64SwitchStack below. Is there anything besides the first if switch, in that function, that works? Can we delete all of it except the first if and the default branch of the first switch?

aarzilli · 2024-12-29T08:49:20Z

pkg/proc/loong64_disasm.go

@@ -0,0 +1,180 @@
+// TODO: disassembler support should be compiled in unconditionally,


Remove this comment.

aarzilli · 2024-12-29T08:52:07Z

pkg/proc/native/proc.go

@@ -372,7 +372,7 @@ func (dbp *nativeProcess) initialize(path string, debugInfoDirs []string) (*proc
 		//	  with gdb once AsyncPreempt was enabled. While implementing the port,
 		//	  few tests failed while it was enabled, but cannot be warrantied that
 		//	  disabling it fixed the issues.
-		DisableAsyncPreempt: runtime.GOOS == "windows" || (runtime.GOOS == "linux" && runtime.GOARCH == "arm64") || (runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le"),
+		DisableAsyncPreempt: runtime.GOOS == "windows" || (runtime.GOOS == "linux" && runtime.GOARCH == "arm64") || (runtime.GOOS == "linux" && runtime.GOARCH == "ppc64le") || (runtime.GOOS == "linux" && runtime.GOARCH == "loong64"),


Every other architecture has an explanation for why asyncpreempt is disabled in the preceding comment, loong64 should also do this. I imagine the reason is the same as linux/arm64.

aarzilli · 2024-12-29T08:52:30Z

pkg/proc/native/proc.go

@@ -382,7 +382,7 @@ func (dbp *nativeProcess) initialize(path string, debugInfoDirs []string) (*proc
 	if err != nil {
 		return nil, err
 	}
-	if dbp.bi.Arch.Name == "arm64" || dbp.bi.Arch.Name == "ppc64le" || dbp.bi.Arch.Name == "riscv64" {
+	if dbp.bi.Arch.Name == "arm64" || dbp.bi.Arch.Name == "ppc64le" || dbp.bi.Arch.Name == "riscv64" || dbp.bi.Arch.Name == "loong64"{


Run gofmt on the files you have changed.

LoongArch is a new RISC ISA, which is independently designed by Loongson Technology. LoongArch includes a reduced 32-bit version (LA32R), a standard 32-bit version (LA32S) and a 64-bit version (LA64), and loong64 is the 64-bit version of LoongArch. LoongArch documentation: https://github.com/loongson/LoongArch-Documentation.git

aarzilli reviewed Mar 12, 2024

View reviewed changes

pkg/gobuild/gobuild.go Outdated Show resolved Hide resolved

pkg/proc/native/support_sentinel_linux.go Outdated Show resolved Hide resolved

abner-chenc reviewed Mar 13, 2024

View reviewed changes

pkg/proc/native/ptrace_linux_64bit.go Outdated Show resolved Hide resolved

yelvens force-pushed the master branch from 1eeae85 to ea44550 Compare October 9, 2024 06:17

abner-chenc reviewed Oct 9, 2024

View reviewed changes

yelvens mentioned this pull request Oct 9, 2024

update golang.org/x/arch to v0.11.0 #3826

Merged

yelvens force-pushed the master branch 2 times, most recently from 804124e to 4cb37fa Compare October 11, 2024 07:56

abner-chenc mentioned this pull request Oct 29, 2024

How to add a new builder #3843

Closed

aarzilli mentioned this pull request Oct 31, 2024

TeamCity: add linux/loong64 builders #3844

Closed

sophie-zhao reviewed Nov 26, 2024

View reviewed changes

pkg/dwarf/regnum/loong64.go Outdated Show resolved Hide resolved

sophie-zhao reviewed Nov 26, 2024

View reviewed changes

pkg/dwarf/regnum/loong64.go Show resolved Hide resolved

yelvens force-pushed the master branch 3 times, most recently from 4bf8dcc to c9573df Compare November 26, 2024 06:51

limeidan reviewed Nov 28, 2024

View reviewed changes

service/debugger/debugger_test.go Outdated Show resolved Hide resolved

limeidan reviewed Nov 28, 2024

View reviewed changes

service/debugger/debugger_unix_test.go Outdated Show resolved Hide resolved

limeidan reviewed Nov 28, 2024

View reviewed changes

pkg/proc/linutil/regs_loong64_arch.go Outdated Show resolved Hide resolved

aarzilli reviewed Nov 28, 2024

View reviewed changes

pkg/gobuild/gobuild.go Outdated Show resolved Hide resolved

aarzilli reviewed Nov 28, 2024

View reviewed changes

limeidan reviewed Dec 2, 2024

View reviewed changes

pkg/proc/pe.go Outdated Show resolved Hide resolved

yelvens force-pushed the master branch 2 times, most recently from 29ec15f to 9a6f0f1 Compare December 3, 2024 09:19

abner-chenc reviewed Dec 6, 2024

View reviewed changes

pkg/proc/native/support_sentinel_linux.go Show resolved Hide resolved

yelvens force-pushed the master branch 3 times, most recently from 14e9755 to 1a72c85 Compare December 11, 2024 01:25

aarzilli reviewed Dec 29, 2024

View reviewed changes

Huang Qiqi added 2 commits December 31, 2024 11:19

*: mark loong64 port as experimental

7873bbb

yelvens force-pushed the master branch from 1a72c85 to 7873bbb Compare December 31, 2024 06:14

yelvens closed this Dec 31, 2024

yelvens mentioned this pull request Dec 31, 2024

support linux-loong64 native debug #3892

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support linux-loong64 native debug #3685

support linux-loong64 native debug #3685

yelvens commented Mar 12, 2024 •

edited

Loading

yelvens commented Mar 12, 2024

aarzilli left a comment

aarzilli commented Mar 12, 2024

derekparker commented Apr 19, 2024

yelvens commented Apr 23, 2024

aarzilli commented Apr 23, 2024

derekparker commented Oct 3, 2024

abner-chenc commented Oct 4, 2024

yelvens commented Oct 9, 2024

abner-chenc left a comment •

edited

Loading

yelvens commented Oct 9, 2024

yelvens commented Oct 11, 2024

aarzilli commented Oct 11, 2024

abner-chenc commented Oct 25, 2024

aarzilli commented Oct 25, 2024

abner-chenc commented Oct 28, 2024 •

edited

Loading

yelvens commented Nov 26, 2024

aarzilli left a comment

aarzilli Nov 28, 2024

yelvens Nov 29, 2024

aarzilli Dec 9, 2024

yelvens Dec 10, 2024

aarzilli Dec 29, 2024

yelvens commented Dec 9, 2024

abner-chenc commented Dec 20, 2024

aarzilli Dec 29, 2024

aarzilli Dec 29, 2024

aarzilli Dec 29, 2024

aarzilli Dec 29, 2024

		@@ -0,0 +1,180 @@
		// TODO: disassembler support should be compiled in unconditionally,

support linux-loong64 native debug #3685

support linux-loong64 native debug #3685

Conversation

yelvens commented Mar 12, 2024 • edited Loading

yelvens commented Mar 12, 2024

aarzilli left a comment

Choose a reason for hiding this comment

aarzilli commented Mar 12, 2024

derekparker commented Apr 19, 2024

yelvens commented Apr 23, 2024

aarzilli commented Apr 23, 2024

derekparker commented Oct 3, 2024

abner-chenc commented Oct 4, 2024

yelvens commented Oct 9, 2024

abner-chenc left a comment • edited Loading

Choose a reason for hiding this comment

yelvens commented Oct 9, 2024

yelvens commented Oct 11, 2024

aarzilli commented Oct 11, 2024

abner-chenc commented Oct 25, 2024

aarzilli commented Oct 25, 2024

abner-chenc commented Oct 28, 2024 • edited Loading

yelvens commented Nov 26, 2024

aarzilli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yelvens commented Dec 9, 2024

abner-chenc commented Dec 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yelvens commented Mar 12, 2024 •

edited

Loading

abner-chenc left a comment •

edited

Loading

abner-chenc commented Oct 28, 2024 •

edited

Loading