-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: add context cancellation reason for server handlers #70850
base: master
Are you sure you want to change the base?
Conversation
When we cancel a HTTP server handler context, set an appropriate cancel cause. This makes investigation of context cancellation errors easier. Fixes golang#64465
This comment was marked as duplicate.
This comment was marked as duplicate.
This PR (HEAD: 124f0d2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/636235. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636235. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/636235. |
Message from Sjors Gielen: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636235. |
Message from Sjors Gielen: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/636235. |
Message from Himanshu Pathak: Patch Set 1: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/636235. |
This PR (HEAD: 29c5a17) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/636235. Important tips:
|
Message from Sjors Gielen: Patch Set 2: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/636235. |
When we cancel a HTTP server handler context, set an appropriate
cancel cause. This makes investigation of context cancellation
errors easier.
Fixes #64465
To do:
net/http
. In order to make the tests succeed, I haven't exposed them, but I think they should be exposed to use witherrors.Is()
. The relevant proposal is at: proposal: net/http: add context cancelation reason for server handlers #64465 (comment)