Compat: Add tests for maxStorage(Buffer/Texture)sIn(Vertex/Fragment)Stage #4118
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I couldn't really think of a test on the core side. Originally I was going to try to request
maxXXXInYYYStage
less thanmaxXXXPerShaderStage
which is what the tests do in compat but in core I believe it will be a no-op and that InStage limits will always match their PerStage counterparts.I added a
RequiredLimitsTestMixin
to try to make it easier to write a test that needs specific limits. The issue is the key. I thought about making the key just be the source ofgetRequiredLimits
but I can imagine someone writing some more generic requester that takes a list of of limits in which case the code would be generic and so using the source of the function would not be a valid key.I also thought about adding a MaxOfSpecificLimitsMixin where you could pass in a list of maxes but I think most code that needs maxes can use MaxLimitsTestMixin
Requirements for PR author:
.unimplemented()
./** documented */
and new helper files are found inhelper_index.txt
.Requirements for reviewer sign-off:
When landing this PR, be sure to make any necessary issue status updates.