Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat: refactor maxStorage(Buffers/Textures)PerShaderStage test #4122

Merged

Conversation

greggman
Copy link
Contributor

@greggman greggman commented Dec 27, 2024

Refactor to handle maxStorage(Buffers/Textures)In(Fragment/Vertex)Stage being less than maxStorage(Buffers/Textures)PerShaderStage

@greggman greggman requested a review from shrekshao December 27, 2024 23:18
@greggman greggman force-pushed the maxStorageTexturesPerShaderStage-inFrag branch from 5e6fa3b to b8beb36 Compare December 30, 2024 19:16
@greggman greggman changed the title Compat: refactor maxStorageTexturesPerShaderStage test Compat: refactor maxStorage(Buffers/Textures)PerShaderStage test Dec 30, 2024
@greggman greggman force-pushed the maxStorageTexturesPerShaderStage-inFrag branch from b8beb36 to f455bfc Compare December 30, 2024 22:52
Copy link
Contributor

@shrekshao shrekshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Refactor to handle maxStorage(Buffers/Textures)In(Vertex/Fragment)Stage
being less than maxStorage(Buffers/Textures)PerShaderStage.

Also maxDynamicStorageBuffersPerPipelineLayout.

I noticed a test was missing there too so added it.
@greggman greggman force-pushed the maxStorageTexturesPerShaderStage-inFrag branch from f455bfc to c1e8ca3 Compare December 31, 2024 01:20
@greggman greggman enabled auto-merge (squash) December 31, 2024 01:20
@greggman greggman merged commit d65f8cb into gpuweb:main Dec 31, 2024
1 check passed
@greggman greggman deleted the maxStorageTexturesPerShaderStage-inFrag branch December 31, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants