Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-distributed] Declare after installation #3479

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

xogoodnow
Copy link
Contributor

Added other components.

p.s:
Enterprise gateway and the Memcached exporter are not included. should they be included as well?

@zalegrala
Copy link
Contributor

Including the enterprise components if enterprise is enabled would be a great update too. Thanks for the PR.

@xogoodnow
Copy link
Contributor Author

Including the enterprise components if enterprise is enabled would be a great update too. Thanks for the PR.

Added all components.
Also changed "gateway.gem.example.com" to "gateway.get.example.com" since its Enterprise Gateway for Traces and not metrics (sorry I'm a little OCD :) ).

Cheers

@xogoodnow
Copy link
Contributor Author

@zalegrala,
This is not related to this PR.

I wanted to send a PR so all ingress sample domains would use {{ .Release.name }} instead of the the hardcoded sample (like the ones in Mimir chart)
If you agree please let me know.

Cheers

@zalegrala
Copy link
Contributor

Alignment in the names with the mimir chart is okay with me. Do we know if this will be a breaking change?

@xogoodnow
Copy link
Contributor Author

Alignment in the names with the mimir chart is okay with me. Do we know if this will be a breaking change?

Great, I do not think it would be a breaking change.
User can provide a domain for all services which have ingress and then override them when needed and the sub-domain for the service would contain the release name such as below:
query-front.{{ {{ .Release.Name }}.example.com

I would open a PR for this then.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants