-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tempo-distributed] Declare after installation #3479
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: xogoodnow <[email protected]>
Including the enterprise components if enterprise is enabled would be a great update too. Thanks for the PR. |
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Added all components. Cheers |
@zalegrala, I wanted to send a PR so all ingress sample domains would use {{ .Release.name }} instead of the the hardcoded sample (like the ones in Mimir chart) Cheers |
Alignment in the names with the mimir chart is okay with me. Do we know if this will be a breaking change? |
Great, I do not think it would be a breaking change. I would open a PR for this then. |
Signed-off-by: Ali <[email protected]>
Signed-off-by: xogoodnow <[email protected]>
Added other components.
p.s:
Enterprise gateway and the Memcached exporter are not included. should they be included as well?