feat: add support for overriding environment label (#824) #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Is there anything I can do to aid with the progression of this being reviewed? |
|
Bump. I'm waiting on this to use Tanka in any capacity since this is a giant footgun that will destroy deployments and eat data. Maintainers, any thoughts? |
julienduchesne
approved these changes
Nov 6, 2024
This change adds support for overriding the environment label using fields on the environment as per grafana#824. To achieve this, the NameLabel() function that generates this needed to be lifted to the Environment struct (from Metadata) to ensure it can access the fields it needs. Additionally, its signature now returns an error as there are ways errors could occur during this generation now that should be surfaced neatly to the user.
julienduchesne
force-pushed
the
feature/824-add-support-for-customizing-env-label-hash
branch
from
a9bc0cd to
894830a
Compare
|
LGTM! |
julienduchesne
changed the title
|
Thanks @DeanBruntThirdfort for this, nice work! |
|
How do we feel about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change looks to add support for the environment label override from fields that #824 requested.
This allows users to alter the label themselves which allows a workaround of the issue described in #824.
As this is my first time contributing, I've not fully tidied this PR up yet as I want to get feedback from the maintainers on whether approach is sound/in-line with the vision of the codebase and if there's anything else I should bear in mind.