Skip to content

Commit

Permalink
chore(deps): upgrade dependencies (#4166)
Browse files Browse the repository at this point in the history
Errata:

Left typescript at v5.4.x as deep dependency typedoc requires v5.4.x.
Left eslint v8.x as not all plugins are compatible with v9.

Code changes, in no particular order:

1. Prettier formatting changes.
2. Prettier moved to an async API, but the `writeGeneratedFile` utility, which previously included prettifying was passed as a callback function to TS and had to stay sync, so prettifying was separated into a separate async function -- the callback function luckily did not seem to actually requiring another round of prettifying, as it just involved renaming. All the other callsites of the new utility had to be made async. In the alternate, I investigated @prettier/sync and the lower-level make-synchronized and make-synchronous packages, but I could not get them working.
3. Plenty of eslint rule changes! I have tried to make sure that the rule list orders now match the linked documentation, so that further updates might be easier.
4. Minor docusaurus config tweaks to get the build to pass.
  • Loading branch information
yaacovCR authored Sep 9, 2024
1 parent 1dbdadc commit 6c56e05
Show file tree
Hide file tree
Showing 34 changed files with 14,425 additions and 9,946 deletions.
314 changes: 117 additions & 197 deletions .eslintrc.cjs

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion benchmark/fixtures.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import fs from 'fs';
import fs from 'node:fs';

export const bigSchemaSDL = fs.readFileSync(
new URL('github-schema.graphql', import.meta.url),
Expand Down
16 changes: 8 additions & 8 deletions benchmark/github-schema.graphql
Original file line number Diff line number Diff line change
Expand Up @@ -3363,7 +3363,7 @@ type CreatedIssueContributionEdge {
Represents either a issue the viewer can access or a restricted contribution.
"""
union CreatedIssueOrRestrictedContribution =
CreatedIssueContribution
| CreatedIssueContribution
| RestrictedContribution

"""
Expand Down Expand Up @@ -3447,7 +3447,7 @@ type CreatedPullRequestContributionEdge {
Represents either a pull request the viewer can access or a restricted contribution.
"""
union CreatedPullRequestOrRestrictedContribution =
CreatedPullRequestContribution
| CreatedPullRequestContribution
| RestrictedContribution

"""
Expand Down Expand Up @@ -3618,7 +3618,7 @@ type CreatedRepositoryContributionEdge {
Represents either a repository the viewer can access or a restricted contribution.
"""
union CreatedRepositoryOrRestrictedContribution =
CreatedRepositoryContribution
| CreatedRepositoryContribution
| RestrictedContribution

"""
Expand Down Expand Up @@ -6635,7 +6635,7 @@ type IssueTimelineConnection {
An item in an issue timeline
"""
union IssueTimelineItem =
Commit
| Commit
| IssueComment
| CrossReferencedEvent
| ClosedEvent
Expand Down Expand Up @@ -6674,7 +6674,7 @@ type IssueTimelineItemEdge {
An item in an issue timeline
"""
union IssueTimelineItems =
IssueComment
| IssueComment
| CrossReferencedEvent
| AddedToProjectEvent
| AssignedEvent
Expand Down Expand Up @@ -12534,7 +12534,7 @@ type PullRequestTimelineConnection {
An item in an pull request timeline
"""
union PullRequestTimelineItem =
Commit
| Commit
| CommitCommentThread
| PullRequestReview
| PullRequestReviewThread
Expand Down Expand Up @@ -12586,7 +12586,7 @@ type PullRequestTimelineItemEdge {
An item in a pull request timeline
"""
union PullRequestTimelineItems =
PullRequestCommit
| PullRequestCommit
| PullRequestCommitCommentThread
| PullRequestReview
| PullRequestReviewThread
Expand Down Expand Up @@ -16467,7 +16467,7 @@ type ReviewRequestRemovedEvent implements Node {
The results of a search.
"""
union SearchResultItem =
Issue
| Issue
| PullRequest
| Repository
| User
Expand Down
1 change: 1 addition & 0 deletions cspell.yml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ words:

# TODO: contribute upstream
- deno
- hashbang

# TODO: remove bellow words
- QLID # GraphQLID
Expand Down
4 changes: 2 additions & 2 deletions integrationTests/node/test.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import childProcess from 'child_process';
import fs from 'fs';
import childProcess from 'node:child_process';
import fs from 'node:fs';

const graphqlPackageJSON = JSON.parse(
fs.readFileSync('./node_modules/graphql/package.json', 'utf-8'),
Expand Down
7 changes: 6 additions & 1 deletion integrationTests/ts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@
"typescript-4.7": "npm:[email protected]",
"typescript-4.8": "npm:[email protected]",
"typescript-4.9": "npm:[email protected]",
"typescript-4.9": "npm:[email protected]"
"typescript-5.0": "npm:[email protected]",
"typescript-5.1": "npm:[email protected]",
"typescript-5.2": "npm:[email protected]",
"typescript-5.3": "npm:[email protected]",
"typescript-5.4": "npm:[email protected]",
"typescript-5.5": "npm:[email protected]"
}
}
6 changes: 3 additions & 3 deletions integrationTests/ts/test.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import childProcess from 'child_process';
import fs from 'fs';
import path from 'path';
import childProcess from 'node:child_process';
import fs from 'node:fs';
import path from 'node:path';

const { dependencies } = JSON.parse(fs.readFileSync('./package.json', 'utf-8'));

Expand Down
2 changes: 1 addition & 1 deletion integrationTests/webpack/test.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import assert from 'assert';
import assert from 'node:assert';

/* eslint-disable n/no-missing-import */
import cjs from './dist/main-cjs.cjs';
Expand Down
Loading

0 comments on commit 6c56e05

Please sign in to comment.