-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding more FAQs answers based on feedback (#1005) #1009
base: source
Are you sure you want to change the base?
Conversation
|
Thanks for this work @Itsaadarsh this is a great start 🙌 |
Hello there @benjie, I've made the changes as you suggested do check them out and let me know if anything else is needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @Itsaadarsh . Just made a couple of small comments and typo suggestions :)
Yes, graphql2chartjs is an open source tool that reshapes your GraphQL data as per the ChartJS API. This makes building charts as easy as simply making a GraphQL query. The idea behind this tool was to leverage GraphQL's realtime subscriptions to build realtime charts by restructuring the GraphQL data to a form that ChartJS expects and generate ChartJS compliant data object from your GraphQL response by simply adding a few aliases in your GraphQL query. | ||
|
||
For more information on graphql2chartjs, check out their [documentation](https://github.com/hasura/graphql2chartjs). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a cool library. But I'm a little concerned that it was last updated in 2019 & has a few open issues suggesting that things aren't working. Do you have any experience with it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I haven't worked with this library yet. So do you want me to remove it?
Hey, @benjie can you review this PR and let me know if something else needs to be changed. |
Closes #1005
Description
I've added more questions to the FAQs section as mentioned on the issue, I've mostly covered all the given question except the following :
Best Practices
Specification
So kindly review them and let me know if any changes are required.