-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: enable prettier for mdx files #1907
base: source
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think all this was migrated but we didn't remove it.
Hold fire on this. |
Okay I dug up the bug with proseWrap in MDX / bug report. Yes, we must disable proseWrap in MDX if we enable prettier; generally I don't trust it with MDX files. I've taken to just un-ignoring each new MDX file I add - perhaps we should ignore certain problematic files but enable? |
@saihaj is it possible to generate the static website before and after this change and assert that there are no differences in the generated output? |
yes. The deploy preview we see on this PR is a version we can compare that with prod. We can build this branch and then try to |
Not sure why we disabled prettier for
.mdx
files. I was working on some other PR and saw it wasn't working so decided to enable for everything.