Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check embedded video start time #2973

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

check embedded video start time #2973

wants to merge 1 commit into from

Conversation

matoushs
Copy link

To allow for specified start times in embedded videos, modify startEmbeddedMedia to check for time syntax.

ie:

<section data-background-video="https://s3.amazonaws.com/static.slid.es/site/homepage/v1/homepage-video-editor.mp4#t=40" data-background-video-loop data-background-video-muted>
</section>

Hbutlercapone
Hbutlercapone approved these changes Jun 30, 2021
View reviewed changes
Copy link

@Hbutlercapone Hbutlercapone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and good to go

@N888-K
Copy link

N888-K commented Jul 1, 2021

@N888-K
Copy link

N888-K commented Jul 1, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Halonoob10 Halonoob10 Halonoob10 approved these changes

@Hbutlercapone Hbutlercapone Hbutlercapone approved these changes

@N888-K N888-K N888-K approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matoushs @N888-K @Hbutlercapone @Halonoob10 @montys2324