Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AlertIOS Fixes #95

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

AlertIOS Fixes #95

wants to merge 4 commits into from

Conversation

Volksfeld
Copy link

I made a commit with the wrong commit message, so sorry :(.
This a simple PR which fixes a minor problem.

Copy link
Collaborator

@phillbaker phillbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a couple more additions of this e.g.

AlertIOS.alert('Authenticated successfully');
can you update there as well?

Sorry for the slow review, thanks again!

@@ -158,7 +158,9 @@ import React, { Component } from 'react';
import PropTypes from 'prop-types';

import {
Alert,


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the extra line breaks here?

@fkotsian fkotsian force-pushed the master branch 2 times, most recently from eaa9e9b to 57556a4 Compare January 27, 2020 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants