-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated Mastodon yaml config import #134040
Remove deprecated Mastodon yaml config import #134040
Conversation
Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@@ -81,38 +80,6 @@ async def async_unload_entry(hass: HomeAssistant, entry: MastodonConfigEntry) -> | |||
) | |||
|
|||
|
|||
async def async_migrate_entry(hass: HomeAssistant, entry: MastodonConfigEntry) -> bool: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we remove this? I don't know when it was implemented but it should be in a separate PR in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I shouldn't have removed that, got carried away with anything that said migrate.
I've added this back.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrew-codechimp 👍
Breaking change
The Mastodon integration moved to config flow in 2024.8 with a deprecation of YAML config scheduled for removal in 2025.2
This PR removes the YAML config import
Proposed change
Tidying up the Mastodon integration by removing now redundant code.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
.To help with the load of incoming pull requests: