Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Mastodon yaml config import #134040

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

andrew-codechimp
Copy link
Contributor

Breaking change

The Mastodon integration moved to config flow in 2024.8 with a deprecation of YAML config scheduled for removal in 2025.2
This PR removes the YAML config import

Proposed change

Tidying up the Mastodon integration by removing now redundant code.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (mastodon) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mastodon can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mastodon Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@andrew-codechimp andrew-codechimp marked this pull request as ready for review December 26, 2024 15:46
@andrew-codechimp andrew-codechimp marked this pull request as draft December 26, 2024 16:20
@andrew-codechimp andrew-codechimp marked this pull request as ready for review December 26, 2024 16:25
@@ -81,38 +80,6 @@ async def async_unload_entry(hass: HomeAssistant, entry: MastodonConfigEntry) ->
)


async def async_migrate_entry(hass: HomeAssistant, entry: MastodonConfigEntry) -> bool:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we remove this? I don't know when it was implemented but it should be in a separate PR in that case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shouldn't have removed that, got carried away with anything that said migrate.
I've added this back.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft December 27, 2024 20:42
@andrew-codechimp andrew-codechimp marked this pull request as ready for review December 28, 2024 08:28
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrew-codechimp 👍

@gjohansson-ST gjohansson-ST merged commit 4639f57 into home-assistant:dev Dec 28, 2024
34 checks passed
@andrew-codechimp andrew-codechimp deleted the mastodon-no-yaml branch December 28, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants