Add weather warning sensor to IPMA #134054
Conversation
| return self._ipma_data | ||
|
|
||
| @property | ||
| def extra_state_attributes(self) -> dict[str, Any] | None: |
There was a problem hiding this comment.
Extra attributes are not great as they are persisted along the state.
Isn't it possible to store them as other sensors? Possibly disabled by default?
There was a problem hiding this comment.
I would agree with that, if it was not for existing integrations that follow this pattern (e.g. meteo-france). And for cards such as https://github.com/MrBartusek/MeteoalarmCard.
Truth be told the extra attributes are actually part of the state, it's just a desegregation of the state.
There was a problem hiding this comment.
I was afraid of that, and it kind ok make sense to have all the related data together.
I tried 😄
| async def test_ipma_warning_create_sensors(hass: HomeAssistant) -> None: | ||
| """Test creation of warning sensors.""" | ||
|
|
||
| with patch("pyipma.location.Location.get", return_value=MockLocation()): |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
I though about that, but it requires some major refactoring of the tests
Will handle test refactoring in a followup PR
Proposed change
Adds a new sensor, providing weather warnings.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: