Remove redundant device update code #134100
Conversation
home-assistant
bot
added
cla-signed
code-quality
core
small-pr
| for attr_name, setvalue in ( | ||
| ("connections", merge_connections), | ||
| ("identifiers", merge_identifiers), | ||
| ): | ||
| old_value = getattr(old, attr_name) | ||
| # If not undefined, check if `value` contains new items. | ||
| if setvalue is not UNDEFINED and not setvalue.issubset(old_value): | ||
| new_values[attr_name] = old_value | setvalue | ||
| old_values[attr_name] = old_value | ||
|
|
There was a problem hiding this comment.
I can see some code paths (looking within this function), where the only place (e.g.) new_values['connections'] is assigned is within the block you are removing.
Please can you help explain why not setting 'connections' in those code paths is ok?
There was a problem hiding this comment.
Can you be more explicit, please? Which code paths exactly do you mean?
There was a problem hiding this comment.
If async_update_device() is called with merge_connections, merge_identifiers, new_connections, new_identifiers all UNDEFINED, then new_values["connections"] and new_values["identifiers"] won't be assigned to anything.
There was a problem hiding this comment.
Which is exactly how it was before. Nothing changes in that case.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Proposed change
Remove redundant device update code.
Those values are handled in the following lines. This is an old code, that no longer serves any function.
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: