Homogeneize generation params #428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This was referenced Dec 9, 2024
…n the models to use other attributes later
clefourrier
force-pushed
the
clem_homogeneize_generation_params
branch
from
071d502 to
286668f
Compare
|
Interestingly, using an explicit generation config seems to mess up this quite a lot |
…ams set by default which slow down generations
…ammatically if needed
NathanHB
reviewed
Dec 16, 2024
Co-authored-by: Nathan Habib <[email protected]> Co-authored-by: Albert Villanova del Moral <[email protected]>
NathanHB
reviewed
Dec 16, 2024
NathanHB
reviewed
Dec 16, 2024
Co-authored-by: Nathan Habib <[email protected]>
…ia the generationparams instead
Co-authored-by: Albert Villanova del Moral <[email protected]>
NathanHB
requested changes
Dec 18, 2024
| @@ -124,6 +127,8 @@ class BaseModelConfig: | |||
| model at a quantized precision. Needed for 4-bit and 8-bit precision. | |||
| trust_remote_code (bool): Whether to trust remote code during model | |||
| loading. | |||
| generation_parameters (GenerationParameters): Range of parameters which will affect the generation. | |||
| generation_config (GenerationConfig): GenerationConfig object (only passed during manual creation) | |||
There was a problem hiding this comment.
I don't understand why we have both generation paramaters and config ?
There was a problem hiding this comment.
If you want to manually create/load your own model (in Python, not using the CLI), you might want to provide it's generation_config directly instead of using the ligtheval generation parameters class
Co-authored-by: Albert Villanova del Moral <[email protected]> Co-authored-by: Nathan Habib <[email protected]>
Co-authored-by: Nathan Habib <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 3 things:
I would put
system_prompt,fewshot_seeds, anduse_chat_templatein the GenerationParameters too since they are generation parameters logically, but it can be another PRCloses #16