Support custom results/details push to hub #457
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| @@ -281,6 +303,31 @@ def push_to_hub( | |||
|
|
|||
| self.recreate_metadata_card(repo_id) | |||
|
|
|||
| def push_results_to_hub(self, repo_id: str, path_in_repo: str, private: bool | None = None): | |||
There was a problem hiding this comment.
Please add some doc, especially to explain the mechanism for the args you added (as they over-write some defaults set at the class level).
There was a problem hiding this comment.
Edit: just saw they were in your todo :)
| @@ -281,6 +303,31 @@ def push_to_hub( | |||
|
|
|||
| self.recreate_metadata_card(repo_id) | |||
|
|
|||
| def push_results_to_hub(self, repo_id: str, path_in_repo: str, private: bool | None = None): | |||
There was a problem hiding this comment.
Shouldn't repo_id be results by default ?
There was a problem hiding this comment.
Same for path_in_repo - do we want to follow as default what we had? (org/modelname/results_date.json)
| self.api.upload_file( | ||
| repo_id=repo_id, | ||
| path_or_fileobj=details_json.encode(), | ||
| path_in_repo=path_in_repo.format(task_name=task_name), |
There was a problem hiding this comment.
Can you provide an example of the expected path_in_repo ?
|
We would also want push_to_hub to use the above 2 functions to avoid logic duplication risk |
Support custom results/details push to hub.
This PR add 2 new methods (
push_results_to_hubandpush_details_to_hub) to allow the user to push results/details to the Hub in a completely customizable way (fully managed by the user).The user can still call the old
push_to_hubmethod to have it fully managed by the library.TODO: