Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refacto generate + use simpler rotary for inference #202

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

3outeille
Copy link
Member

No description provided.

@3outeille 3outeille requested a review from xrsrke June 25, 2024 11:54
@3outeille 3outeille mentioned this pull request Jun 25, 2024
@3outeille 3outeille force-pushed the refacto-generate-3 branch from d5bf8e3 to f33e818 Compare June 25, 2024 12:03
@3outeille 3outeille marked this pull request as ready for review June 25, 2024 12:04
Copy link
Member

@xrsrke xrsrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

# Preallocate memory for output logits.
logits = None
if parallel_context.is_pipeline_last_stage:
logits = torch.empty((seq_len, batch_size, model.config.vocab_size), dtype=torch.float32, device=device)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to define it here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants