-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mobile): fix text search #14873
base: main
Are you sure you want to change the base?
fix(mobile): fix text search #14873
Conversation
This commit f59b813 changed how Passing empty string at the context or the filename filter is necessary to remove the filter when the user submits the search field with no text. The I think this answers both of the above questions. |
Can you please write down some functional test cases and how you verified that they are fixed with this change? |
sure I will write some tests to verify that the search is working as inteded. If these tests existed this commit f59b813 would have failed them. |
Needed for SearchPage test to not throw overflow error
Fixes #14814