Support touchstart, focus, blur events in link prefetch
#2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m5r
commented
Dec 13, 2024
| @@ -165,7 +165,7 @@ const Link = forwardRef<unknown, InertiaLinkProps>( | |||
| }, prefetchModes) | |||
|
|
|||
| const regularEvents = { | |||
| onClick: (event) => { | |||
| onClick: (event: Parameters<InertiaLinkProps['onClick']>[0]) => { | |||
There was a problem hiding this comment.
This looks a bit ugly but it's basically reusing the type of the first parameter of the onClick property defined in InertiaLinkProps above
m5r
commented
Dec 13, 2024
| click: regularEvents.click, | ||
| } | ||
| } satisfies ActionEventHandlers |
There was a problem hiding this comment.
I replaced the type assignment with the satisfies operator to make autocomplete smarter. Now typescript knows which properties from ActionEventHandlers are defined and which aren't while still validating the types are correct.
m5r
commented
Dec 13, 2024
| @@ -51,11 +51,11 @@ test('can prefetch using link props', async ({ page }) => { | |||
|
|
|||
| await page.getByRole('link', { name: 'On Mount' }).click() | |||
| await isPrefetchPage(page, 2) | |||
| await expect(requests.requests.length).toBe(0) | |||
| expect(requests.requests.length).toBe(0) | |||
There was a problem hiding this comment.
awaits here were not necessary, expect().toBe() doesn't return a promise, it's all synchronous
m5r
force-pushed
the
expand-prefetch-behavior
branch
from
4d726f2 to
c9e0aa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for
touchstart,focus, andblurevents in link prefetchhoverbehavior.This is hugely inspired from React Router's link prefetching code. Their event handlers composition is pretty neat too but I don't think it's necessary here.