Create 160_Flugans_Stolta_Gång_på_rullgardinen #20
Conversation
|
Yes, i would definitely change that, if i knew hoe to ... I'm not completely sure how i made the pull request to begin with... Edit |
Added composer: Otto Lindblad and removed the By tag
Changed Kräftans to flugans... as that is what it should be
There was a problem hiding this comment.
Great first PR!
A couple of mostly small, and mostly technical, comments:
-
composerneeds to be on it's own line, otherwise the parser Is going to believe that the melody isLängtan till landet (Vintern rasat) composer: Otto Lindblad - Title and Melody should not be capitalized, the parser only recognizes the specific words
titleandmelody - There should be a space between
tags:and[snaps, swedish] - The name of the file should capitalize words the same way the title does – this doesn't affect anything, but it's good practice to be consistent across all files.
- When searching around it seems that the far more common version is
Kräftans stolta gång på rullgardinen. So unless the Flugan-version is more commonly used within the IN-chapter I think it's preferable to use the more standard version.
Then like @Cactooz has said you also need to "rebuild" the project. Right now it is somewhat complicated, so we're happy to help you out with that when everything's ready ^^
Edit: If you need any help with anything regarding this PR just give me a ping and I'll try my best to be of use
…ans_stolta_sång_på_rullgardinen @StelFoog I have put composer on it's own line, but i would like it to be noted that it is the composer of the melody, not the writer of theese lyrics. I have fixed the other issues. Regarding what is more common, my own searches gave me three common results. Flugan, Kräftan and Loppan. Since i have never heard of anyone besides me in IN-sektionen that knows of this, i would say that flugan is the most commonly used in IN. Also, kräftan is more specific for kräftskiva, whie flugan and loppan are more general versions. One could perhaps include the alternate version for Kräftskiva also? i will gladly accept help with buidinig
There was a problem hiding this comment.
The name of the file seems to accidentally have become Flugans_stolta_sång_på_rullgardinen instead of gång, I also forgot to mention before that file names should avoid åäö and instead use aao (this is to make it easier to search for songs for people who don't have Swedish keyboards).
Apart from that everything else looks good :)
As regards the composer – composer is specifically to define who wrote the melody. The author of the lyrics is defined by the author.
…gang_pa_rullgardinen Changed name of file from "sång" to "gång", also removed Å,Ä,Ö from file name
|
Seems like the file is missing the markdown file format ( If you could rebase this (and your other PR) – |
…ans_stolta_gang_pa_rullgardinen.md
Fun, classic song