Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPR: Better color management to support themed css #877

Open
wants to merge 24 commits into
base: develop
Choose a base branch
from

Conversation

a2nt
Copy link
Contributor

@a2nt a2nt commented Jan 4, 2023

Current color theme is Catpuchin Mocha

An example to switch light/dark included at src/scss/global/colours_theme.scss:

$red-light-bg: darken($red, 20%);
$turquoise-light-bg: darken($turquoise, 20%);

.light-theme {
  --color-red: #{$red-light-bg};
  --color-turquoise: #{$turquoise-light-bg};
}

.dark-theme {
  --color-mid_grey: #{$subtext1};
}

A color theme can be imported at src/scss/global/colours.scss For example:
@import "mocha";

@a2nt a2nt changed the base branch from master to develop January 4, 2023 16:07
@jaedb
Copy link
Owner

jaedb commented Jan 5, 2023

Nice work! It looks like you've got some other changes in this PR not related to the theme changes you've been working on. Can you please split this out? PRs should be (reasonably) self-contained bodies of work - that makes it a great deal easier to review, patch and schedule for release.

@a2nt
Copy link
Contributor Author

a2nt commented Jan 5, 2023

There's also locale update I can remove it. Some other css changes comes up from automatic linter, but looks like default project linter doesn't works properly

npm lint:fix
/home/tony/Downloads/Software/Iris/src/js/App.js
  0:0  error  Parsing error: require() of ES Module /home/tony/Downloads/Software/Iris/node_modules/.pnpm/[email protected]/node_modules/eslint-scope/lib/definition.js from /home/tony/Downloads/Software/Iris/node_modules/.pnpm/[email protected][email protected]/node_modules/babel-eslint/lib/require-from-eslint.js not supported.
Instead change the require of definition.js in /home/tony/Downloads/Software/Iris/node_modules/.pnpm/[email protected][email protected]/node_modules/babel-eslint/lib/require-from-eslint.js to a dynamic import() which is available in all CommonJS modules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants