-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated azure dependencies fixes #89 #90
base: master
Are you sure you want to change the base?
Conversation
I pulled down your code and did a local build, but still get the same auth-header error...
|
After looking at the Dockerfile, I think it's just pulling down a binary of the last build... I'll keep looking. Would love to validate this for you (which would mean it works for all of us!) |
I was not able to get it working either. Had issues with the setup of the build environment. The xenolf/Lego guys told me to update the libraries. |
Unfortunately, i don't know |
I made a new Dockerfile for reference (run from repo root):
|
That dockerfile is downloading janeczku/rancher-letsencrypt repo the fixes for the authentication header are in annerajb/rancher-letsencrypt. If you modify the dockerfile it causes another issue I have no idea why people do this in GO.... but I haven't worked more than 2 hours with it.(for fixing this issue) |
and obviously circleci failed since it's hardcoded to only pull this repository.... to the go vendor folder. |
Maybe anybody with access to the original repo can help on how to update that go dependency? To this same repo? |
@annerajb nobody did deploy your fix? |
nope i ended up using the cname option.
…On Tue, Feb 12, 2019 at 4:48 PM Patrick Machado ***@***.***> wrote:
@annerajb <https://github.com/annerajb> nobody did deploy your fix?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#90 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA14XgEIeHJDaEfVhL6GV53y-e42A-VYks5vMzaigaJpZM4O0uYv>
.
|
Fixes #89
Can you verify this?