Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated azure dependencies fixes #89 #90

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

annerajb
Copy link

Fixes #89

Can you verify this?

@dzirkler
Copy link

I pulled down your code and did a local build, but still get the same auth-header error...

8/11/2017 11:34:23 AMtime="2017-08-11T18:34:23Z" level=error msg="[mydomain.com] Error obtaining certificate: Error presenting token: dns.ZonesClient#Get: Failure responding to request: StatusCode=401 -- Original Error: autorest/azure: Service returned an error. Status=401 Code=\"AuthenticationFailed\" Message=\"Authentication failed. The 'Authorization' header is missing.\""

@dzirkler
Copy link

After looking at the Dockerfile, I think it's just pulling down a binary of the last build... I'll keep looking. Would love to validate this for you (which would mean it works for all of us!)

@annerajb
Copy link
Author

I was not able to get it working either. Had issues with the setup of the build environment. The xenolf/Lego guys told me to update the libraries.

@dzirkler
Copy link

Unfortunately, i don't know go ... so we'll see!

@dzirkler
Copy link

I made a new Dockerfile to make sure I was picking up the new build, and looks like it's still generating the error, so unfortunately updating the libraries hasn't resolved this issue...

Dockerfile for reference (run from repo root):

FROM golang:alpine AS build-env
RUN apk add --update make git 
WORKDIR /src
ADD . .
RUN go get github.com/Sirupsen/logrus
RUN go get github.com/janeczku/rancher-letsencrypt/letsencrypt
RUN make build

# final stage
FROM alpine:3.5
COPY --from=build-env /src/build/rancher-letsencrypt-linux-amd64 /usr/bin/rancher-letsencrypt
COPY package/rancher-entrypoint.sh /usr/bin/
RUN apk add --no-cache ca-certificates openssl bash &&\
    wget -O /usr/bin/update-rancher-ssl https://raw.githubusercontent.com/rancher/rancher/08278ace626ada71384fc949bd637f4c15b03b53/server/bin/update-rancher-ssl && \
    chmod +x /usr/bin/update-rancher-ssl &&\
    chmod +x /usr/bin/rancher-letsencrypt

EXPOSE 80
ENTRYPOINT ["/usr/bin/rancher-entrypoint.sh"]

@annerajb
Copy link
Author

annerajb commented Aug 12, 2017

That dockerfile is downloading janeczku/rancher-letsencrypt repo the fixes for the authentication header are in annerajb/rancher-letsencrypt.

If you modify the dockerfile it causes another issue
The context.go requires updating from looking for janeczku/rancher-letsencrypt to annerajb/rancher-letsencrypt.

I have no idea why people do this in GO.... but I haven't worked more than 2 hours with it.(for fixing this issue)

@annerajb
Copy link
Author

and obviously circleci failed since it's hardcoded to only pull this repository.... to the go vendor folder.

@annerajb
Copy link
Author

Maybe anybody with access to the original repo can help on how to update that go dependency? To this same repo?

@p1Machado
Copy link

@annerajb nobody did deploy your fix?

@annerajb
Copy link
Author

annerajb commented Feb 24, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants