[JENKINS-73640] Use AWS SDK for Java 2.x #1021
Draft
+1,874
−1,468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil
commented
Dec 17, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
basil
commented
Dec 17, 2024
Comment on lines
+2833
to
+2834
| if (type != null && !type.isEmpty()) { | ||
| type = (new InstanceTypeCompat(type)).getInstanceType().toString(); | ||
| } |
There was a problem hiding this comment.
Compatibility with serialized XStream XML.
Comment on lines
+350
to
+351
| this.type = type != null && !type.isEmpty() | ||
| ? (new InstanceTypeCompat(type)).getInstanceType().toString() | ||
| : null; |
basil
force-pushed
the
JENKINS-73640
branch
3 times, most recently
from
bbe9216 to
00add16
Compare
Co-authored-by: Denis Blanchette <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See JENKINS-73640. Builds on the work started by @dblanchette to migrate this plugin to AWS SDK for Java 2.x. The main improvement over the initial contribution is that I have fixed all integration tests so that
mvn clean verifypasses. I have not attempted to test this plugin against a real AWS account.Testing done
mvn clean verifySubmitter checklist