Fix to cap very large position values #1206
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen in some situations when using nimble media server. The position values can come though as what looks like close to max int64 values such as 9223372036850115913
Which causes the following error when flutter tries to convert the value to a using DateTime.fromMillisecondsSinceEpoch().
RangeError (millisecondsSinceEpoch): Invalid value: Not in inclusive range -8640000000000000..8640000000000000: 9223372036850115913
Our guess is this only happens with streams that don't have an end (such as tv).
The below patch checks the value and accordingly returns null if the value for position exceeded what the datetime can handle.
This issue has been raised in the following two reports:
#1068
#884