-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text-only prompt element for console-ui #1138
base: master
Are you sure you want to change the base?
Conversation
da89289
to
129477c
Compare
Looks good!
I think we can open an other ticket/pull request for ConsolePrompt's methods visibility changes |
Good idea!
I actually tried that and couldn't get it to work right. Let me try again and if I can't figure it out I'll give a shout for help :-)
Ok, btw, do you perhaps see a way to "retrofit" the now deprecated methods so they can be used with this new prompt method? I've been racking my brain but I can't think of a good solution. Sure, we can add them with a different name, eg |
textPrompt results should be removed also here
Update your project. I have merged the fix #1133.
I have created the ticket #1141 with some guide lines... |
8be6f3e
to
c672016
Compare
c672016
to
125be8c
Compare
@mattirn updated the PR with your suggestions |
Fixes #1136
First stab at implementing this new text-only element. It won't win any beauty contests, but it works. WDYT @mattirn ?
NB: I considered creating a
TextPrompt
and usingConsoleUIItemIF
for the lines of theText
element, but between the fact thatTextPrompt
would be mostly empty (because we're not actually asking for input) , the fact that items only deal withStrings
, notAttributedStrings
and the fact that eachXxxxPrompt
only displays a single line of result it just wasn't a good fit.