Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Sidebar position sticky #1086

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

techmannih
Copy link
Contributor

What kind of change does this PR introduce?
This PR introduces a sticky sidebar position, allowing the sidebar to remain fixed in view while the user scrolls down the page.

Issue Number:
Issue #774
Closes #774

Screenshots/videos:

20241030144432.mp4

@techmannih techmannih requested a review from a team as a code owner October 30, 2024 09:31
Copy link

github-actions bot commented Oct 30, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview ab281bb

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (718dab5) to head (ab281bb).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1086   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DhairyaMajmudar DhairyaMajmudar changed the title add: sidebar position sticky Fix: Sidebar position sticky Oct 30, 2024
@DhairyaMajmudar DhairyaMajmudar added the Hacktoberfest Issues accepeted Hacktoberfest'24 label Oct 30, 2024
@DhairyaMajmudar
Copy link
Member

@techmannih the sidebar should be sticky to such high extend.

image

@techmannih
Copy link
Contributor Author

@DhairyaMajmudar I’m unable to understand your point. Please explain. I think it's sticky also

@DhairyaMajmudar
Copy link
Member

@DhairyaMajmudar I’m unable to understand your point. Please explain. I think it's sticky also

I meant the sidebar should not be sticky to upto need help headline only below that the footer sections are there.

@techmannih
Copy link
Contributor Author

you mean change the height
now it covers full "need help" section
image

@techmannih
Copy link
Contributor Author

@DhairyaMajmudar Could you please clarify what you need? I’m having some difficulty understanding.

@DhairyaMajmudar
Copy link
Member

DhairyaMajmudar commented Nov 10, 2024

@techmannih I was worried about the less bottom margin for the sidebar cause of which it was getting patched up with need help section you can check the video below

Screencast.from.2024-11-10.12-07-28.webm

The expected behavior should be like this : )

Screencast.from.2024-11-10.12-10-15.webm

@techmannih
Copy link
Contributor Author

techmannih commented Nov 10, 2024

Thanks @DhairyaMajmudar, it's a great clarification! Now I get your point clearly. please review now

@techmannih
Copy link
Contributor Author

@DhairyaMajmudar @benjagm take a look this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Sidebar position Sticky
2 participants