Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: invalidate surcharge cache during update #6907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: invalidate surcharge cache during update #6907

wants to merge 1 commit into from

Conversation

hrithikesh026
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

When surcharge rules where updated or deleted, the in memory cache was being invalidated using the wrong key. Fixed that issue in this PR.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@hrithikesh026 hrithikesh026 added C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Dec 20, 2024
@hrithikesh026 hrithikesh026 self-assigned this Dec 20, 2024
@hrithikesh026 hrithikesh026 requested a review from a team as a code owner December 20, 2024 09:07
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Dec 20, 2024 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/core/surcharge_decision_config.rs  34% smaller

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Narayanbhat166 Narayanbhat166 Awaiting requested review from Narayanbhat166

@Aprabhat19 Aprabhat19 Awaiting requested review from Aprabhat19

At least 2 approving reviews are required to merge this pull request.

Assignees

@hrithikesh026 hrithikesh026

Labels
C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hrithikesh026